[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11989: ✏️ request metrics type to counter

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #11989:
URL: https://github.com/apache/dubbo/pull/11989#discussion_r1161352591


##########
dubbo-spring-boot/dubbo-spring-boot-observability-starter/pom.xml:
##########
@@ -69,6 +69,11 @@
             <groupId>io.micrometer</groupId>
             <artifactId>micrometer-registry-prometheus</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.dubbo</groupId>
+            <artifactId>dubbo-metrics-prometheus</artifactId>
+            <version>${project.version}</version>
+        </dependency>

Review Comment:
   Just add related dependency here directly. Do not transitively depend on the entire package.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org