[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #749: Convert Spark In filter to iceberg IN Expression

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #749: Convert Spark In filter to iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373746033
 
 

 ##########
 File path: spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
 ##########
 @@ -543,11 +579,11 @@ private File buildPartitionedTable(String desc, PartitionSpec spec, String udf,
 
   private List<Record> testRecords(org.apache.avro.Schema avroSchema) {
     return Lists.newArrayList(
-        record(avroSchema, 0L, timestamp("2017-12-22T09:20:44.294658+00:00"), "junction"),
+        record(avroSchema, 0L, timestamp("2017-12-22T09:20:44.294+00:00"), "junction"),
 
 Review comment:
   Why was it necessary to change these values? This doesn't change the hour partitions the values are stored in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org