[GitHub] [commons-compress] andrebrait commented on pull request #345: COMPRESS-613: Support for extra time data in Zip archives

[GitBox <gi...@apache.org>]

andrebrait commented on PR #345:
URL: https://github.com/apache/commons-compress/pull/345#issuecomment-1367860607

   > I just want to raise awareness that a similar change I have done for the tar format in [COMPRESS-404](https://issues.apache.org/jira/browse/COMPRESS-404) has lead to problems with reproducible builds (see [COMPRESS-583](https://issues.apache.org/jira/browse/COMPRESS-583)). I don't know if something similar could happen here too.
   
   Oh, you mean files built using these? Yes, I know this could do that, but it was already setting modification dates. Access date would change on each access, (provided the filesystem supports it and isn't mounted with e.g. noatime), though.
   
   I guess I could make setting those things optional with a parameter on the constructor or a static constructor for them, but other than that, there isn't that much that can be done if the filesystem gives something different all the time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org