[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21739: build: Make Docker image extensible

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #21739:
URL: https://github.com/apache/superset/pull/21739#discussion_r990570950


##########
Dockerfile:
##########
@@ -77,6 +77,7 @@ RUN cd /app \
     && pip install --no-cache -r requirements/local.txt
 
 COPY --from=superset-node /app/superset/static/assets /app/superset/static/assets
+COPY --from=superset-node /app/superset-frontend /app/superset-frontend

Review Comment:
   The huge directory `node_modules` is in `superset-frontend` so I think it's not a good idea to copy this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org