[GitHub] [netbeans-native-installers] ebarboni commented on a diff in pull request #3: init build system for cleaner/launcher

[GitBox <gi...@apache.org>]

ebarboni commented on code in PR #3:
URL: https://github.com/apache/netbeans-native-installers/pull/3#discussion_r1053152946


##########
src/main/cpp/cleaner/windows/Makefile.mingw:
##########
@@ -16,5 +14,18 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-# 
 
+TMPFLD = ../../../../../target/tmp/
+OFLD = ../../../../../target/cleaner/
+
+all: prepfolder cleaner.exe
+
+prepfolder:
+	mkdir -p $(TMPFLD)
+	mkdir -p $(OFLD)
+
+clean:
+	rm -f *.res *.exe *.dll
+
+cleaner.exe: src/main.c
+	x86_64-w64-mingw32-gcc -s -DARCHITECTURE=64 -Wl,--nxcompat -Wl,--dynamicbase -Wl,--no-seh -Wl,--no-insert-timestamp -mwindows src/main.c -o$(OFLD)cleaner.exe -static -lstdc++ -static-libstdc++ -static-libgcc

Review Comment:
   I only target x64 as it was done in the launcher repo this way. There is only one cleaner.exe in the zip ([nbi](https://netbeans.osuosl.org/binaries/2B892D9E648A792EDB0F705378E06F84C322E208-nbi.engine-external-binaries-11.zip)) that I cannot determine the architecture.
   
   cleaner.exe and others are used in the harness/libs.nbi.engine project in netbeans main repo (meged in a jar) and used in sequence in the nbm-maven-harness that is used to generate installer linux/windows for people using nbm-maven plugin. (may later be replaced with nbpacker but needs coding 😄 )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists