You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/06/15 15:51:31 UTC

[GitHub] [arrow] felipecrv opened a new pull request, #36102: MINOR: [C++] Make clang-tidy stop complaining about arrays in Arrow

felipecrv opened a new pull request, #36102:
URL: https://github.com/apache/arrow/pull/36102

   ### Rationale for this change
   
   `std::array` is rarely a good fit for the kind of low-level array and buffer manipulation that Arrow does, so having `clang-tidy` complaining about C-style arrays confuses more than it helps.
   
   ### What changes are included in this PR?
   
   Change in `.clang-tidy`.
   
   ### Are these changes tested?
   
   I checked on my editor. Warnings not shown anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36102: MINOR: [C++] Make clang-tidy stop complaining about C arrays

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36102:
URL: https://github.com/apache/arrow/pull/36102#issuecomment-1598070222

   Conbench analyzed the 6 benchmark runs on commit `d55cfaa7`.
   
   There were 3 benchmark results indicating a performance regression:
   
   - Commit Run on `arm64-t4g-linux-compute` at [2023-06-19 15:52:34Z](http://conbench.ursa.dev/compare/runs/61f082f4c00842d69a5842002773ebeb...aa54cff861dd489bb844d721d27668b0/)
     - [params=<STATIC_VECTOR(int)>, source=cpp-micro, suite=arrow-small-vector-benchmark](http://conbench.ursa.dev/compare/benchmarks/06490692db3373a38000768bae896962...064907a096b2784e80000ae4a14b56fe)
   
   - Commit Run on `arm64-m6g-linux-compute` at [2023-06-19 15:43:17Z](http://conbench.ursa.dev/compare/runs/758e1763a46b4115b0b856a60508d486...31e1c3cba5f6412ab142dab5e41fc542/)
     - [params=num_cols:64/is_partial:0/real_time, source=cpp-micro, suite=arrow-ipc-read-write-benchmark](http://conbench.ursa.dev/compare/benchmarks/06490682607577d7800081485a611ade...0649077e3e40745b8000d0dd35a7106a)
   - and 1 more (see the report linked below)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/14391327162) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou merged pull request #36102: MINOR: [C++] Make clang-tidy stop complaining about C arrays

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #36102:
URL: https://github.com/apache/arrow/pull/36102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on pull request #36102: MINOR: [C++] Make clang-tidy stop complaining about arrays in Arrow

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #36102:
URL: https://github.com/apache/arrow/pull/36102#issuecomment-1593328454

   @pitrou @bkietz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on pull request #36102: MINOR: [C++] Make clang-tidy stop complaining about C arrays

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #36102:
URL: https://github.com/apache/arrow/pull/36102#issuecomment-1593434057

   > This sounds good to me. It seems our standard lint routine does not run clang-tidy, does it?
   
   No, but there is an issue about enabling it https://github.com/apache/arrow/issues/35214
   
   Part of the fix is fixing the warnings or disabling some of them like I'm doing here. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org