You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by WeichenXu123 <gi...@git.apache.org> on 2018/04/05 10:32:22 UTC
[GitHub] spark pull request #20982: [SPARK-23859][ML] Initial PR for Instrumentation ...
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20982
[SPARK-23859][ML] Initial PR for Instrumentation improvements: UUID and logging levels
## What changes were proposed in this pull request?
Initial PR for Instrumentation improvements: UUID and logging levels.
This PR takes over #20837
Closes #20837
## How was this patch tested?
Manual.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/spark better-instrumentation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20982.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20982
----
commit 42c3eca78a58ddca059b150681a0deaf462981f8
Author: Bago Amirbekian <ba...@...>
Date: 2018-03-15T18:14:48Z
Log data about logistic regression.
commit bef1084283f66fcd3ec5be3d14f30b206b7c45a5
Author: Bago Amirbekian <ba...@...>
Date: 2018-03-29T21:48:48Z
Have instrumentation use uuid & standard logger tags.
commit 8a3ce3e4958420dc5e92e7c1d31d5eab1735bb9e
Author: Bago Amirbekian <ba...@...>
Date: 2018-03-30T23:34:15Z
Add logWarning to instrumentation class.
commit f05bcdf32f5709a1a4b1b4fc433ac88dedc5d1ae
Author: WeichenXu <we...@...>
Date: 2018-04-05T10:29:29Z
add logError and fix typo
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20982: [SPARK-23859][ML] Initial PR for Instrumentation ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20982
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20982
**[Test build #88938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88938/testReport)** for PR 20982 at commit [`f05bcdf`](https://github.com/apache/spark/commit/f05bcdf32f5709a1a4b1b4fc433ac88dedc5d1ae).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20982
**[Test build #88938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88938/testReport)** for PR 20982 at commit [`f05bcdf`](https://github.com/apache/spark/commit/f05bcdf32f5709a1a4b1b4fc433ac88dedc5d1ae).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20982
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2002/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88938/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20982
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/20982
LGTM
Merging with master
Thanks @WeichenXu123 and @MrBago !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org