You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "adarsh-jha-dev (via GitHub)" <gi...@apache.org> on 2023/10/28 11:39:46 UTC
[PR] Add Table of Contents to README [shardingsphere]
adarsh-jha-dev opened a new pull request, #28885:
URL: https://github.com/apache/shardingsphere/pull/28885
Fixes #
There are no existing issues for this, this is a suggested change.
Changes proposed in this pull request:
- Added a table of contents to the README to improve navigation within the document.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Table of Contents to README [shardingsphere]
Posted by "adarsh-jha-dev (via GitHub)" <gi...@apache.org>.
adarsh-jha-dev commented on PR #28885:
URL: https://github.com/apache/shardingsphere/pull/28885#issuecomment-1784006990
I request any of the maintainers to please have a look at this PR and let me know if the changes are relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Table of Contents to README [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on code in PR #28885:
URL: https://github.com/apache/shardingsphere/pull/28885#discussion_r1400029836
##########
README.md:
##########
@@ -18,9 +18,25 @@
[](https://twitter.com/ShardingSphere)
-| **Stargazers Over Time** | **Contributors Over Time** |
-|:---------------------------------------------------------------------------------------------------------------------:|:------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------:|
-| [](https://starchart.cc/apache/shardingsphere) | [](https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/shardingsphere) |
Review Comment:
What is the reason to remove table contents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Table of Contents to README [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #28885:
URL: https://github.com/apache/shardingsphere/pull/28885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org