You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/18 20:26:12 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Ouss4 opened a new pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421
## Summary
.d directories are common for holding config and init scripts.
They are being ignored with the global *.d pattern which is meant to
ignore Make dependency files.
We had this discussion before and #1373 fixed the issue only for the etc/ directory under boards/sim.
With this PR every directory with the .d extension will be tracked.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456825471
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
I am conflicted on this one because shouldn't we allow anything in this folder? I guess going forward we should just be careful when people force the inclusion of a file and instead have a specific git ignore exception for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456826446
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
That change was part of #1373 to solve the *.d issue. I don't know if we should allow anything in that folder, if you think we should I can bring it back.
> I guess going forward we should just be careful when people force the inclusion of a file and instead have a specific git ignore exception for it.
I agree with this. But does this apply to this change? I guess somehow it does since at the very beginning the idea was to bring the rcS file back.
But what I'm trying to do is to have a general way to include *.d folders since we may have more of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456857599
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
@Ouss4 @btashton how about we change !*.d/ to !init.d/ or !etc/? since etc/ is packaged into romfs, files contained by etc can be any types that .gitignore is hard to anticipate and then ignore correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456888340
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
> I think I would be OK with adding the !*.d/ rule at the top because there really is no reason to ever exclude that, but opening up everything inside the folder I think we should be doing as needed and at the board level.
The folder still ignores toplevel patterns. So it's not completely open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456857775
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
The reason that I don't really like handling this at the top level gitignore is that is is really board configuration specific. Do we add `home` `lib` `bin` etc..
I think I would be OK with adding the !*.d/ rule at the top because there really is no reason to ever exclude that, but opening up everything inside the folder I think we should be doing as needed and at the board level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456857069
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
@Ouss4 @btashton how about we change !*.d/ to !init.d/ or !etc/? since etc/ is packaged into romfs, files contained by etc can be any types that .gitignore is hard to anticipate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456826446
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
That change was part of #1373 to solve the *.d issue. I don't know if we should allow anything in that folder, if you think we should I can bring it back.
> I guess going forward we should just be careful when people force the inclusion of a file and instead have a specific git ignore exception for it.
I agree with this. But does this apply to this change? I guess somehow it does since at the very beginning the idea was to bring the rcS file back.
But what I'm trying to do is the have a general way to include *.d folders since we may have more of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456857069
##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
/etctmp*
-!/etc/**
Review comment:
@Ouss4 @btashton how about we change !*.d/ to !init.d/ or !etc/? since etc/ is packaged into romfs, files contained by etc can be any types that .gitignore is hard to anticipate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org