You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/16 15:36:26 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17

dongjoon-hyun commented on a change in pull request #34022:
URL: https://github.com/apache/spark/pull/34022#discussion_r710236231



##########
File path: dev/mima
##########
@@ -41,6 +41,12 @@ else
   JAVA_CMD=java
 fi
 
+# Workaround to make mima runs on Java 17+
+JAVA_VER=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1)
+if [[ JAVA_VER -ge 17 ]]; then

Review comment:
       Could you extend this for Java 11, too? `-ge 11` instead of `-ge 17`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org