You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2009/08/06 06:22:14 UTC
[jira] Created: (HIVE-729) select expression with optional "as"
select expression with optional "as"
------------------------------------
Key: HIVE-729
URL: https://issues.apache.org/jira/browse/HIVE-729
Project: Hadoop Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Zheng Shao
Assignee: Zheng Shao
Priority: Minor
Attachments: HIVE-729.1.patch
"as" should be optional in select expression. Query like the following should work:
{code}
SELECT a, b FROM (
SELECT key a, value b
FROM src
) src1
ORDER BY a LIMIT 1;
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-729) select expression with optional "as"
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740267#action_12740267 ]
Namit Jain commented on HIVE-729:
---------------------------------
I agree - the test output can be changed
+1
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch, HIVE-729.2.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-729) select expression with optional "as"
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-729:
----------------------------
Attachment: HIVE-729.1.patch
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-729) select expression with optional "as"
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo updated HIVE-729:
-------------------------------
Attachment: HIVE-729.2.patch
Uploaded patch with the fixed test case.
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch, HIVE-729.2.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-729) select expression with optional "as"
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-729:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Zheng
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch, HIVE-729.2.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-729) select expression with optional "as"
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740212#action_12740212 ]
Raghotham Murthy commented on HIVE-729:
---------------------------------------
looks good. will commit if tests pass.
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-729) select expression with optional "as"
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740242#action_12740242 ]
Ashish Thusoo commented on HIVE-729:
------------------------------------
I think it is safe to change this test. Since the column alias is optional the statement treats the second expression as a column alias due to the lack of , and since this expression is not an identifier it barfs. What do you think? I can generate a new patch that has Zheng's fixes and the test output update.
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-729) select expression with optional "as"
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740235#action_12740235 ]
Raghotham Murthy commented on HIVE-729:
---------------------------------------
there was one test failure:
[junit] diff /mnt/vol/devrs005.snc1/rmurthy/hive-committer/build/ql/test/logs/negative/invalid_select.q.out /mnt/vol/devrs005.snc1/rmurthy/hive-committer/ql/src/test/results/compiler/errors/i
nvalid_select.q.out
[junit] 1c1
[junit] < Parse Error: line 3:6 mismatched input '(' expecting FROM in from clause
[junit] ---
[junit] > Parse Error: line 3:2 mismatched input 'trim' expecting FROM in from clause
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-729) select expression with optional "as"
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-729:
----------------------------
Fix Version/s: 0.4.0
Status: Patch Available (was: Open)
> select expression with optional "as"
> ------------------------------------
>
> Key: HIVE-729
> URL: https://issues.apache.org/jira/browse/HIVE-729
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: HIVE-729.1.patch
>
>
> "as" should be optional in select expression. Query like the following should work:
> {code}
> SELECT a, b FROM (
> SELECT key a, value b
> FROM src
> ) src1
> ORDER BY a LIMIT 1;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.