You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by dk...@apache.org on 2023/02/14 13:32:04 UTC
[hive] branch master updated: HIVE-27075: removeDuplicateCompletedTxnComponents() task must start only if compactions are enabled. (Simhadri Govindappa, reviewed by Denys Kuzmenko)
This is an automated email from the ASF dual-hosted git repository.
dkuzmenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new d2cce718abc HIVE-27075: removeDuplicateCompletedTxnComponents() task must start only if compactions are enabled. (Simhadri Govindappa, reviewed by Denys Kuzmenko)
d2cce718abc is described below
commit d2cce718abc66da64bf696bc725fb1cb1d3c29ef
Author: SimhadriGovindappa <si...@gmail.com>
AuthorDate: Tue Feb 14 19:01:52 2023 +0530
HIVE-27075: removeDuplicateCompletedTxnComponents() task must start only if compactions are enabled. (Simhadri Govindappa, reviewed by Denys Kuzmenko)
Closes #4055
---
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java | 2 ++
.../org/apache/hadoop/hive/metastore/txn/AcidHouseKeeperService.java | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java b/ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
index 82eef64125b..5f046946e1e 100644
--- a/ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
+++ b/ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
@@ -3495,6 +3495,8 @@ public class TestDbTxnManager2 extends DbTxnManagerEndToEndTestBase{
@Test
public void testRemoveDuplicateCompletedTxnComponents() throws Exception {
dropTable(new String[] {"tab_acid"});
+ MetastoreConf.setBoolVar(conf, MetastoreConf.ConfVars.COMPACTOR_INITIATOR_ON, true);
+ MetastoreConf.setBoolVar(conf, MetastoreConf.ConfVars.COMPACTOR_CLEANER_ON, true);
driver.run("create table if not exists tab_acid (a int) partitioned by (p string) " +
"stored as orc TBLPROPERTIES ('transactional'='true')");
diff --git a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidHouseKeeperService.java b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidHouseKeeperService.java
index 8fd66506846..0a16006c49e 100644
--- a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidHouseKeeperService.java
+++ b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidHouseKeeperService.java
@@ -82,8 +82,8 @@ public class AcidHouseKeeperService implements MetastoreTaskThread {
performTask(txnHandler::performTimeOuts, "Cleaning timed out txns and locks");
performTask(txnHandler::performWriteSetGC, "Cleaning obsolete write set entries");
performTask(txnHandler::cleanTxnToWriteIdTable, "Cleaning obsolete TXN_TO_WRITE_ID entries");
- performTask(txnHandler::removeDuplicateCompletedTxnComponents, "Cleaning duplicate COMPLETED_TXN_COMPONENTS entries");
if (isCompactorEnabled) {
+ performTask(txnHandler::removeDuplicateCompletedTxnComponents, "Cleaning duplicate COMPLETED_TXN_COMPONENTS entries");
performTask(txnHandler::purgeCompactionHistory, "Cleaning obsolete compaction history entries");
}
}