[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4764: Fix the bug of releasing the segment when there are still threads working on it

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4764: Fix the bug of releasing the segment when there are still threads working on it
URL: https://github.com/apache/incubator-pinot/pull/4764#discussion_r341276592
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/operator/CombineGroupByOperator.java
 ##########
 @@ -224,6 +241,8 @@ public void runJob() {
           future.cancel(true);
         }
       }
+      // Deregister the main thread and wait for all threads done
 
 Review comment:
   In line 179, don't you need to issue a cacel on the futures, and then jump down to awaitAndDeregister()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org