You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 18:34:06 UTC
[GitHub] [arrow] wesm opened a new pull request, #13557: [C++] Revert changes to vector_selection.cc to try to fix RTools mingw32 failure
wesm opened a new pull request, #13557:
URL: https://github.com/apache/arrow/pull/13557
I made some unnecessary changes to this file in #13521 so seeing if reverting them fixes the observed issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13557: ARROW-16757: [C++][FOLLOWUP] Fix mingw32 RTools 4.0 build by removing usage of alignas
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13557:
URL: https://github.com/apache/arrow/pull/13557#issuecomment-1179448380
https://issues.apache.org/jira/browse/ARROW-16757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13557: [C++] Revert changes to vector_selection.cc to try to fix RTools mingw32 failure
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13557:
URL: https://github.com/apache/arrow/pull/13557#issuecomment-1179447488
@nealrichardson @wjones127 @pitrou @paleolimbot so bizarrely, I had mistakenly used `alignas(64)` instead of `alignas(8)` with a struct member I added in #13521 -- I don't think that 64-byte alignment for that buffer should necessarily cause something to go wrong, but perhaps this mingw32 in question has a broken implementation of the C++11 `alignas` keyword? Really strange. In any case I'll clean this up and merge it so builds will stop failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13557: [C++] Revert changes to vector_selection.cc to try to fix RTools mingw32 failure
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13557:
URL: https://github.com/apache/arrow/pull/13557#issuecomment-1179428442
I added some checks to prevent the filter implementations from running in the 0-length chunked array cases, and a different filter test started failing:
```R
test_that("[ accepts Arrays and otherwise handles bad input", {
vec <- 11:20
a <- Array$create(vec)
ind <- c(9, 3, 5)
expect_error(
a[Array$create(ind)],
"Cannot extract rows with an Array of type double"
)
expect_as_vector(a[Array$create(ind - 1, type = int8())], vec[ind])
expect_as_vector(a[Array$create(ind - 1, type = uint8())], vec[ind])
expect_as_vector(a[ChunkedArray$create(8, 2, 4, type = uint8())], vec[ind])
filt <- seq_along(vec) %in% ind
expect_as_vector(a[Array$create(filt)], vec[filt])
expect_error(
a["string"],
"Cannot extract rows with an object of class character"
)
})
```
This is good because it's a normal array being filtered, but I'm still perplexed why #13521 would have caused this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm merged pull request #13557: ARROW-16757: [C++][FOLLOWUP] Fix mingw32 RTools 4.0 build by removing usage of alignas
Posted by GitBox <gi...@apache.org>.
wesm merged PR #13557:
URL: https://github.com/apache/arrow/pull/13557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13557: [C++] Revert changes to vector_selection.cc to try to fix RTools mingw32 failure
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13557:
URL: https://github.com/apache/arrow/pull/13557#issuecomment-1179263187
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org