[GitHub] [jena] kinow commented on pull request #1712: Bump json5 from 1.0.1 to 1.0.2 in /jena-fuseki2/jena-fuseki-ui

[GitBox <gi...@apache.org>]

kinow commented on PR #1712:
URL: https://github.com/apache/jena/pull/1712#issuecomment-1374796850

   >json5 seems to be a dependency of babel-core.
   >
   >Should we do a general update of versions across the UI?
   
   Yup, we can bump every dependency as long as unit and e2e tests work afterwards.
   
   >And I see two errors (which don't look too serious):
   
   Ah, yes. I've seen these two before. I believe we have only a dependency to `yasqe` and `yasr`. `yasgui` is a [peer dependency](https://nodejs.org/es/blog/npm/peer-dependencies/) of these two.
   
   Their [dev docs](https://triply.cc/docs/yasgui-api) show YASGUI as a binding dependency to both YASQE and YASR, but we do not use YASGUI directly. I **think** you need to install the peer dependency if you use the YAS* plug-ins,
   
   >Triply provides additional plugins that are only free to use via https://yasgui.triply.cc/ or [TriplyDB](https://triplydb.com/)
   
   But it won't hurt adding `yasgui` directly to remove these warnings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org