You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/09 01:38:02 UTC

[GitHub] [dubbo] plusmancn commented on a change in pull request #8730: rename rpc h2 settings key

plusmancn commented on a change in pull request #8730:
URL: https://github.com/apache/dubbo/pull/8730#discussion_r704886083



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
##########
@@ -55,7 +56,7 @@ public void close() {
 
     @Override
     public void configServerPipeline(ChannelPipeline pipeline, SslContext sslContext) {
-        final Configuration config = ConfigurationUtils.getGlobalConfiguration();
+        final Configuration config = ConfigurationUtils.getGlobalConfiguration(ApplicationModel.defaultModel());

Review comment:
       Is the `defaultModel` always ok?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org