You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/03 22:27:19 UTC
[GitHub] [trafficcontrol] mattjackson220 opened a new pull request #4254:
updated TP to use API 1.5 and TO perl to use 1.5
mattjackson220 opened a new pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
This PR updates Traffic Portal to use API version 1.5 and updates TO perl to accept requests to API 1.5
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR is not related to any Issue <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Ops
- Traffic Portal
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
Verify that requests from TP go to the 1.5 API and that TO perl accepts requests to the 1.5 API
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4254: updated TP to
use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570723754
> _"TO-Go doesn't yet serve any 1.5 routes yet"_
That's right, idk what's wrong with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request
#4254: updated TP to use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#discussion_r362983784
##########
File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
##########
@@ -64,6 +64,12 @@ sub define {
# Traffic Stats Extension 1.4
$self->traffic_stats_routes( $r, $version );
+ # 1.5 Routes
Review comment:
🚨 wee woo 🚨
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp commented on issue #4254: updated TP to
use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570721674
> IDK if that's necessarily true, TO (go) already serves 1.5 and making TO (perl) do it rounds out that support, so TP should be fine. Anything else is pinned to <= 1.4 so it won't care.
TO-Go doesn't yet serve any 1.5 routes yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #4254: updated
TP to use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
ocket8888 edited a comment on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570723754
> _"TO-Go doesn't yet serve any 1.5 routes yet"_
That's right, idk what's wrong with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 merged pull request #4254: updated TP
to use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request
#4254: updated TP to use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#discussion_r362983171
##########
File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
##########
@@ -64,6 +64,12 @@ sub define {
# Traffic Stats Extension 1.4
$self->traffic_stats_routes( $r, $version );
+ # 1.5 Routes
Review comment:
the formatting police are going to get you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4254: updated TP to
use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570721048
IDK if that's necessarily true, TO (go) already serves 1.5 and making TO (perl) do it rounds out that support, so TP should be fine. Anything else is pinned to <= 1.4 so it won't care.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4254: updated TP
to use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570718993
Pretty sure this PR can NOT be merged until #4198 is merged. #4198 is the PR that introduces api 1.5 and is necessary before you can make calls to 1.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull
request #4254: updated TP to use API 1.5 and TO perl to use 1.5
Posted by GitBox <gi...@apache.org>.
mattjackson220 commented on a change in pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#discussion_r362985423
##########
File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
##########
@@ -64,6 +64,12 @@ sub define {
# Traffic Stats Extension 1.4
$self->traffic_stats_routes( $r, $version );
+ # 1.5 Routes
Review comment:
fixed. sorry about that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services