You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/02 18:08:04 UTC
[jira] [Commented] (ZOOKEEPER-2795) Change log level for
"ZKShutdownHandler is not registered" error message
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035153#comment-16035153 ]
ASF GitHub Bot commented on ZOOKEEPER-2795:
-------------------------------------------
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/273
ZOOKEEPER-2795 Change log level for "ZKShutdownHandler is not registered" error message
`ZKShutdownHandler` may not be registered if the user creates a `ZooKeeperServer` object outside of `ZooKeeperServerMain.runFromConfig`.
We should change the log level of the message that is printed on state changes of `ZooKeeperServer` when `ZKShutdownHandler` is missing to something lower.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2795
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit 36c7e4df9a127775d1d0840faacae0ea0ced8304
Author: Abraham Fine <af...@apache.org>
Date: 2017-06-02T17:50:29Z
ZOOKEEPER-2795: Change log level for "ZKShutdownHandler is not registered" error message
----
> Change log level for "ZKShutdownHandler is not registered" error message
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
> Issue Type: Wish
> Affects Versions: 3.4.10, 3.5.3
> Reporter: Andy Chambers
> Assignee: Abraham Fine
> Priority: Trivial
>
> We have an integration test suite that starts up an embedded version of zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes
> My java is a bit rusty but I think I can't create one of these shutdown handlers from outside the "org.apache.zookeeper.server" package because the constructor has not been marked "public". Would it be possible to do so?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)