Re: cvs commit: apachen/src/test time-sem.c

[Marc Slemko <ma...@worldgate.com>]

On 22 Jan 1998 jim@hyperreal.org wrote:

> jim         98/01/22 15:12:10
> 
>   Modified:    .        STATUS
>                htdocs/manual/misc FAQ.html perf-tuning.html
>                htdocs/manual/mod core.html
>                src      CHANGES PORTING
>                src/main conf.h http_main.c httpd.h
>                src/os/win32 os.h
>                src/test time-sem.c
>   Log:
>   Submitted by:	Jim Jagielski
>   
>   Do make the code a bit clearer, some minor #define changes (and
>   the resultant flow-thru in the docs).
>   
>      SAFE_UNSERIALIZED_ACCEPT  ->   SINGLE_LISTEN_UNSERIALIZED_ACCEPT
>      HAVE_MMAP                 ->   USE_MMAP_SCOREBOARD
>      HAVE_SHMGET               ->   USE_SHMGET_SCOREBOARD

Would it be better to keep HAVE_MMAP and HAVE_SHMGET and add defines for
what to use for the scoreboard, that default to something depending on
what HAVE_ are defined yet can be overriden in the OS-specific parts or
elsewhere?

There _is_ a use for HAVE_MMAP, etc. and could be more uses in the
future.  Consider adding a generic shared memory interface, then you
need yet more defines and they are all based on seperate things that
all have to be set for each platform.

Re: cvs commit: apachen/src/test time-sem.c

[Dean Gaudet <dg...@arctic.org>]

On Thu, 22 Jan 1998, Marc Slemko wrote:

> There _is_ a use for HAVE_MMAP, etc. and could be more uses in the
> future.  Consider adding a generic shared memory interface, then you
> need yet more defines and they are all based on seperate things that
> all have to be set for each platform.

I suppose it could be USE_MMAP_SHARED_MEM instead of
USE_MMAP_SCOREBOARD...

Note that HAVE_MMAP doesn't tell you that you've got mmap() with anonymous
capabilities or with BSD semantics as opposed to sysv semantics...

Dean