[GitHub] tardieu opened a new pull request #3897: Do not abort conductor action execution when component action is invalid, not found, not accessible or when composition is too long

[GitBox <gi...@apache.org>]

tardieu opened a new pull request #3897: Do not abort conductor action execution when component action is invalid, not found, not accessible or when composition is too long
URL: https://github.com/apache/incubator-openwhisk/pull/3897
 
 
   <!--- Provide a concise summary of your changes in the Title -->
   
   Conductor actions currently abort when they fail to execute a component action with no possibility to catch the error and recover. This PR makes it possible to handle several failure scenarios.
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   
   With this PR, the following failure scenarios can now be handled by the conductor action code:
   - parsing failure,
   - resolution failure,
   - entitlement check failure,
   - excessive number of component action activations.
   
   With this PR, a conductor action can reliably invoke a callback upon completion, whereas currently a simple typo in the name of a component action aborts the execution and prevents the callback to run.
   
   The unit and system tests for conductor actions have been updated to confirm that the conductor action invocation does not abort in these scenarios.
   
   The documentation of conductor actions has been updated to reflect this new behavior.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [x] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [x] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   While this change breaks the existing behavior for these failure scenarios, this current behavior is undesirable.
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services