You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/26 10:51:06 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #17976: Remove SchemaMetaDataLoader and move load metadata logic to GenericSchemaBuilder

strongduanmu opened a new pull request, #17976:
URL: https://github.com/apache/shardingsphere/pull/17976

   Changes proposed in this pull request:
   - remove SchemaMetaDataLoader
   - move load metadata logic to GenericSchemaBuilder
   - add new build method in GenericSchemaBuilder to replace SchemaMetaDataLoader#load
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #17976: Remove SchemaMetaDataBuilder and move load metadata logic to GenericSchemaBuilder

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #17976:
URL: https://github.com/apache/shardingsphere/pull/17976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove SchemaMetaDataBuilder and move load metadata logic to GenericSchemaBuilder [shardingsphere]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17976:
URL: https://github.com/apache/shardingsphere/pull/17976#issuecomment-4183099168

   ## [Codecov](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `53.70370%` with `25 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 59.00%. Comparing base ([`8442124`](https://app.codecov.io/gh/apache/shardingsphere/commit/8442124985cab30ef10bcbfa6229fe984d06df4a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c28ebe7`](https://app.codecov.io/gh/apache/shardingsphere/commit/c28ebe770bf7bcca0a068aca91ce0c3e518f6501?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 15042 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [.../database/schema/builder/GenericSchemaBuilder.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&filepath=shardingsphere-infra%2Fshardingsphere-infra-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fmetadata%2Fdatabase%2Fschema%2Fbuilder%2FGenericSchemaBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvYnVpbGRlci9HZW5lcmljU2NoZW1hQnVpbGRlci5qYXZh) | 62.85% | [9 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...nfra/metadata/database/ShardingSphereDatabase.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&filepath=shardingsphere-infra%2Fshardingsphere-infra-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fmetadata%2Fdatabase%2FShardingSphereDatabase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...esher/type/AlterTableStatementSchemaRefresher.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&filepath=shardingsphere-infra%2Fshardingsphere-infra-context%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fcontext%2Frefresher%2Ftype%2FAlterTableStatementSchemaRefresher.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9BbHRlclRhYmxlU3RhdGVtZW50U2NoZW1hUmVmcmVzaGVyLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...resher/type/AlterViewStatementSchemaRefresher.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&filepath=shardingsphere-infra%2Fshardingsphere-infra-context%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fcontext%2Frefresher%2Ftype%2FAlterViewStatementSchemaRefresher.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9BbHRlclZpZXdTdGF0ZW1lbnRTY2hlbWFSZWZyZXNoZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...sher/type/CreateTableStatementSchemaRefresher.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&filepath=shardingsphere-infra%2Fshardingsphere-infra-context%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fcontext%2Frefresher%2Ftype%2FCreateTableStatementSchemaRefresher.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9DcmVhdGVUYWJsZVN0YXRlbWVudFNjaGVtYVJlZnJlc2hlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...esher/type/CreateViewStatementSchemaRefresher.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&filepath=shardingsphere-infra%2Fshardingsphere-infra-context%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fcontext%2Frefresher%2Ftype%2FCreateViewStatementSchemaRefresher.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9DcmVhdGVWaWV3U3RhdGVtZW50U2NoZW1hUmVmcmVzaGVyLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/shardingsphere/mode/manager/ContextManager.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&filepath=shardingsphere-mode%2Fshardingsphere-mode-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmode%2Fmanager%2FContextManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9Db250ZXh0TWFuYWdlci5qYXZh) | 66.66% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17976      +/-   ##
   ============================================
   + Coverage     58.99%   59.00%   +0.01%     
     Complexity     2141     2141              
   ============================================
     Files          3642     3643       +1     
     Lines         54018    54022       +4     
     Branches       9186     9186              
   ============================================
   + Hits          31868    31878      +10     
   + Misses        19437    19431       -6     
     Partials       2713     2713              
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shardingsphere/pull/17976?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org