You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/05 23:59:52 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4200: Regex checker UI improvements
mbien opened a new pull request, #4200:
URL: https://github.com/apache/netbeans/pull/4200
wanted to check out the new regex checker with a fairly long regex (output window exception matcher from #4180), but noticed that the text fields had all fixed sizes despite it being a top component.
So I tried to fix this first ;)
- everything resizes now properly (the example generator window too)
- added vertical splitter as bonus
- moved the error msg label a little bit around (try invalid regex)
- noticed that the form had a unused JFrame stored, removed that (might have been the first version of the RegexExampleGeneratorPanel)
before.
after:
@mishrasandeep what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4200:
URL: https://github.com/apache/netbeans/pull/4200#issuecomment-1147563151
should be fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4200:
URL: https://github.com/apache/netbeans/pull/4200#issuecomment-1147816257
> Definitely an improvement. Though to my eye the "Strict Check" checkbox is "floating" around, out of context. Also I do not see the two buttons down there in the 3rd of June dev builds. Am I missing something?
the check box probably deserves a tool tip which explains what it does. (I actually don't know, would have to check the code myself).
the buttons were added in #3252, which was post NB 14 freeze. If you build master you should see them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4200:
URL: https://github.com/apache/netbeans/pull/4200#issuecomment-1147752899
Definitely an improvement. Though to my eye the "Strict Check" checkbox is "floating" around, out of context.
Also I do not see the two buttons down there in the 3rd of June dev builds. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mishrasandeep commented on pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
mishrasandeep commented on PR #4200:
URL: https://github.com/apache/netbeans/pull/4200#issuecomment-1147288301
@mbien It looks good. Can a horizontal scrolling option also be added when the example text box is small but the input is lengthy (multiple lines)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mishrasandeep commented on pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
mishrasandeep commented on PR #4200:
URL: https://github.com/apache/netbeans/pull/4200#issuecomment-1147974107
@mbien The highlights that we above are the substrings that are matching the regular expression. Strict check will basically check for the entire string and show a no match even if there are substrings that match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4200:
URL: https://github.com/apache/netbeans/pull/4200#issuecomment-1152535495
I just force pushed to add a tooltip for the check box.
The text area has a graphical "glitch". The green check mark is overdrawn if the scroll bar is used (on linux at least), I don't see this as a show stopper for now.
There are certainly some more tweaks possible to further improve it - but this could be done in other PRs as you said. Going to merge once green again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4200:
URL: https://github.com/apache/netbeans/pull/4200#issuecomment-1147466773
> It looks good. Can a horizontal scrolling option also be added when the example text box is small but the input is lengthy (multiple lines)?
@mishrasandeep good catch. I'll take a look why the scroll bar doesn't show up - it should be there agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4200: Regex checker UI improvements
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4200:
URL: https://github.com/apache/netbeans/pull/4200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists