You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "lpiob (via GitHub)" <gi...@apache.org> on 2023/03/12 10:19:49 UTC
[GitHub] [apisix-helm-chart] lpiob opened a new pull request, #508: HPA and PDB updated to Kubernetes 1.25
lpiob opened a new pull request, #508:
URL: https://github.com/apache/apisix-helm-chart/pull/508
Why:
* Chart could not be installed in Kubernetes 1.25
* The PodDisruptionBudget and HorizontalPodAutoscaling used apiVersion that were deprecated before and unavailable in 1.25.
This change addresses the need by:
* PodDisruptionBudget apiVersion is updated to match the Kubernetes version. No spec adjustments needed.
* HorizontalPodAutoscaling apiVersion is updated to match the Kubernetes version.
* HorizontalPodAutoscaling spec adjusted to new api version.
* Changes are applied also to k8s versions in which old api versions were deprecated.
Reference:
* https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125
* https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125
I have tested the changes on a 1.25 cluster and reviewed templates visually for older version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] lpiob commented on pull request #508: PDB updated to Kubernetes 1.25
Posted by "lpiob (via GitHub)" <gi...@apache.org>.
lpiob commented on PR #508:
URL: https://github.com/apache/apisix-helm-chart/pull/508#issuecomment-1465199696
> This PR can only keep PDB
I've updated the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #508: PDB updated to Kubernetes 1.25
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #508:
URL: https://github.com/apache/apisix-helm-chart/pull/508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] lpiob commented on pull request #508: HPA and PDB updated to Kubernetes 1.25
Posted by "lpiob (via GitHub)" <gi...@apache.org>.
lpiob commented on PR #508:
URL: https://github.com/apache/apisix-helm-chart/pull/508#issuecomment-1465153896
I've just noticed that this PR partially duplicates the #468.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] RSteeno commented on pull request #508: PDB updated to Kubernetes 1.25
Posted by "RSteeno (via GitHub)" <gi...@apache.org>.
RSteeno commented on PR #508:
URL: https://github.com/apache/apisix-helm-chart/pull/508#issuecomment-1520606170
What is the process to get additional reviewers to look at this? I'm currently in need of this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #508: HPA and PDB updated to Kubernetes 1.25
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #508:
URL: https://github.com/apache/apisix-helm-chart/pull/508#issuecomment-1465182604
Thanks for your contribution. For HPA, I this #468 is good.
This PR can only keep PDB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #508: PDB updated to Kubernetes 1.25
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #508:
URL: https://github.com/apache/apisix-helm-chart/pull/508#issuecomment-1612303604
@RSteeno If there is no timely follow-up due to the maintainer having too many messages and tasks, please feel free to ping me. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org