[jira] [Commented] (S2GRAPH-135) Change the way LabelIndexOption is implemented and improve it

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712250#comment-15712250 ] 

ASF GitHub Bot commented on S2GRAPH-135:
----------------------------------------

GitHub user daewon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/103

    [S2GRAPH-135] Change the way LabelIndexOption is implemented and improve it

    I changed the functionality of 'labelIndexOption' as described in {{S2GRAPH-135}} issue.
    
    When this PR is merged, you can set different options for each direction(in, out) through the 'options' field in 'LabelIndex' table.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-135

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit 20bdf9291acfbb830db441490e1d5351fa8a0ca3
Author: daewon <da...@apache.org>
Date:   2016-12-01T15:11:04Z

    [S2GRAPH-135] Change the way LabelIndexOption is implemented and improve it

----


> Change the way LabelIndexOption is implemented and improve it
> -------------------------------------------------------------
>
>                 Key: S2GRAPH-135
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-135
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: Daewon Jeong
>            Assignee: Daewon Jeong
>            Priority: Minor
>
> https://lists.apache.org/thread.html/e9c9237c5468fd899f693352eb23cc514280df41d0d11ae8e51fac97@%3Cdev.s2graph.apache.org%3E
> I hope the LabelIndexOption has changed as suggested in the above link.
> LabelIndex option
> When creating a label index, create a direction item in the optionos field.
> - 'labelIndex' works for both directions.
> -  If there is no specific option, all of them expect to be true. (store indexEdge, store degree)
> -  If you want to apply a specific option for a specific direction, specify the direction in 'option'.
> Definition
> Ex)
>   in direction: drop indexEdge, drop degree  
>   out direction: store indexEdge, store degree 
> {code:title=LabelIndexOption|borderStyle=solid}
> {
>     "out": {
>         "method": "drop",
>         "storeDegree": false
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)