You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/07/17 11:23:56 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #979: Submarine 1294. Add simple type authentication for REST api
cdmikechen opened a new pull request, #979:
URL: https://github.com/apache/submarine/pull/979
### What is this PR for?
Add simple type authentication for REST api.
Use [pac4j](https://www.pac4j.org/index.html) for token generation and validation. Considering need to adapt to java8, this PR is using 4.5.6 instead of version pac4j 5 for the time being.
### What type of PR is it?
Feature
### Todos
* [x] - Add some configs for authentication
* [x] - Add `SimpleFilter`
* [x] - Modified some login api processing logic (no logout available yet)
* [x] - Add test case
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1294
### How should this be tested?
Have added a test case in `org.apache.submarine.server.security.SubmarineAuthSimpleTest`
### Screenshots (if appropriate)
No
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? Yes
* Does this need new documentation? Yes(link: https://github.com/apache/submarine/pull/975)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #979: SUBMARINE-1294. Add simple type authentication for REST api
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #979: SUBMARINE-1294. Add simple type authentication for REST api
URL: https://github.com/apache/submarine/pull/979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #979: SUBMARINE-1294. Add simple type authentication for REST api
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #979:
URL: https://github.com/apache/submarine/pull/979#issuecomment-1188477913
# [Codecov](https://codecov.io/gh/apache/submarine/pull/979?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#979](https://codecov.io/gh/apache/submarine/pull/979?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2fff5bd) into [master](https://codecov.io/gh/apache/submarine/commit/e7ed4a5b182a7cc3cad32f406a8327e6c788d966?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7ed4a5) will **increase** coverage by `0.37%`.
> The diff coverage is `70.00%`.
```diff
@@ Coverage Diff @@
## master #979 +/- ##
===========================================
+ Coverage 9.18% 9.55% +0.37%
- Complexity 670 698 +28
===========================================
Files 234 240 +6
Lines 23716 23832 +116
Branches 3475 3478 +3
===========================================
+ Hits 2178 2278 +100
- Misses 21407 21420 +13
- Partials 131 134 +3
```
| [Impacted Files](https://codecov.io/gh/apache/submarine/pull/979?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/submarine/server/SubmarineServer.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9TdWJtYXJpbmVTZXJ2ZXIuamF2YQ==) | `62.28% <20.00%> (-1.25%)` | :arrow_down: |
| [.../submarine/server/rest/workbench/LoginRestApi.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9yZXN0L3dvcmtiZW5jaC9Mb2dpblJlc3RBcGkuamF2YQ==) | `60.00% <57.14%> (+60.00%)` | :arrow_up: |
| [...server/security/simple/SimpleSecurityProvider.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9zZWN1cml0eS9zaW1wbGUvU2ltcGxlU2VjdXJpdHlQcm92aWRlci5qYXZh) | `66.66% <66.66%> (ø)` | |
| [...submarine/server/security/common/CommonConfig.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9zZWN1cml0eS9jb21tb24vQ29tbW9uQ29uZmlnLmphdmE=) | `75.00% <75.00%> (ø)` | |
| [...che/submarine/server/security/SecurityFactory.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9zZWN1cml0eS9TZWN1cml0eUZhY3RvcnkuamF2YQ==) | `78.57% <78.57%> (ø)` | |
| [...rine/server/security/simple/SimpleLoginConfig.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9zZWN1cml0eS9zaW1wbGUvU2ltcGxlTG9naW5Db25maWcuamF2YQ==) | `87.50% <87.50%> (ø)` | |
| [...submarine/server/security/simple/SimpleFilter.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9zZWN1cml0eS9zaW1wbGUvU2ltcGxlRmlsdGVyLmphdmE=) | `92.30% <92.30%> (ø)` | |
| [...che/submarine/commons/utils/SubmarineConfVars.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy11dGlscy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL2NvbW1vbnMvdXRpbHMvU3VibWFyaW5lQ29uZlZhcnMuamF2YQ==) | `75.80% <100.00%> (+0.59%)` | :arrow_up: |
| [...submarine/server/security/common/CommonFilter.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL3NlcnZlci9zZWN1cml0eS9jb21tb24vQ29tbW9uRmlsdGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ubmarine/commons/utils/SubmarineConfiguration.java](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy11dGlscy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL2NvbW1vbnMvdXRpbHMvU3VibWFyaW5lQ29uZmlndXJhdGlvbi5qYXZh) | `36.72% <0.00%> (+1.12%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/submarine/pull/979/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/submarine/pull/979?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/submarine/pull/979?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e7ed4a5...2fff5bd](https://codecov.io/gh/apache/submarine/pull/979?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org