You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "xuang7 (via GitHub)" <gi...@apache.org> on 2026/02/25 04:03:12 UTC
[PR] fix: convert BubbleChart boolean field to Python-compatible value [texera]
xuang7 opened a new pull request, #4238:
URL: https://github.com/apache/texera/pull/4238
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
This PR adds an explicit boolean conversion in BubbleChartOpDesc. It fixes an issue where the Scala boolean field enableColor was rendered in the new Python template as lowercase true/false instead of True/False. This caused a runtime error: NameError: name 'false' is not defined.
Demo:
<img width="700" height="738" alt="bubblechart" src="https://github.com/user-attachments/assets/d2811da5-beb9-4d8d-89f8-cca544f93e68" />
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234`
or `Closes #1234`. If it is only related, simply mention the issue number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
No
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if the PR
is tested with existing test cases. Make sure to include/update test cases that
check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how
you tested step by step, ideally copy and paste-able, so that other reviewers can
test and check, and descendants can verify in the future. If tests were not added,
please describe why they were not added and/or why it was difficult to add.
-->
Manually tested
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4238:
URL: https://github.com/apache/texera/pull/4238#issuecomment-4002123442
@carloea2 Is your suggested change taken care of? If so, we can merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #4238:
URL: https://github.com/apache/texera/pull/4238#issuecomment-4265860337
> Why hasn't this PR been merged?
Jiadong is busy. I will merge it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #4238:
URL: https://github.com/apache/texera/pull/4238#issuecomment-4001777150
> LGTM. Please explain briefly how the current fix solves the problem
Thanks for the suggestion. I have updated the PR description with a short explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #4238:
URL: https://github.com/apache/texera/pull/4238#issuecomment-4008683721
@chenlica this PR LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #4238:
URL: https://github.com/apache/texera/pull/4238#issuecomment-4265883546
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #4238:
URL: https://github.com/apache/texera/pull/4238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #4238:
URL: https://github.com/apache/texera/pull/4238#issuecomment-4008481421
> @carloea2 Is your suggested change taken care of? If so, we can merge this PR.
Yes, I've applied @carloea2 suggested fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #4238:
URL: https://github.com/apache/texera/pull/4238#issuecomment-4265835022
Why hasn't this PR been merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org