You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/06/15 09:57:18 UTC
[GitHub] [camel] ppalaga opened a new pull request, #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
ppalaga opened a new pull request, #10403:
URL: https://github.com/apache/camel/pull/10403
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594381869
> We have formatter and impsort [enabled by default](https://github.com/apache/camel-quarkus/blob/main/poms/build-parent/pom.xml#L169-L194) in `process-sources` phase in Camel Quarkus since years. I works quite well, because one typically builds before pushing/committing. This is the most newcomer friendly setup I can imagine and love it in all projects where they have it. The project defines the style and the newcomer does not need to care or even know.
That would be one possibility too. I'd say we should try that before the hook.
>
> I never used formatting in a pre-commit hook. Do you have some real world experience with that? Would it work regardless what is the current working directory? Doesn't it take too long for large projects?
I haven't used it in Camel, specifically, but in general: yes, it would work regardless of the directory. Git uses the project base directory for running the hooks, so it would work regardless of the directory.
The biggest challenge is making it running quickly: you wouldn't want this to run on all the project (that would be very slow), and just on the modified modules/projects containing changes on Java files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594364331
We have formatter and impsort [enabled by default](https://github.com/apache/camel-quarkus/blob/main/poms/build-parent/pom.xml#L169-L194) in `process-sources` phase in Camel Quarkus since years. I works quite well, because one typically builds before pushing/committing. This is the most newcomer friendly setup I can imagine and love it in all projects where they have it. The project defines the style and the newcomer does not need to care or even know.
I never used formatting in a pre-commit hook. Do you have some real world experience with that? Would it work regardless what is the current working directory? Doesn't it take too long for large projects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1593799654
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1593198038
> > Actually mvnd 1.0-m6-m39-linux-amd64 uses maven-resolver 1.9.7 which I am sure suffers from the socket timeouts in the very same way as the older mvnd 0.8.2. Here is an example seen in #10372 :
> > ```
> > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack (process-sources) on project camel-spring-xml: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1: Failed to read artifact descriptor for org.ow2.asm:asm:jar:7.3.1: The following artifacts could not be resolved: org.ow2.asm:asm:pom:7.3.1 (absent): Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out -> [Help 1]
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack (process-sources) on project camel-spring-xml: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> > at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:347)
> > at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:330)
> > at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> > at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> > at org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:76)
> > at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> > at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> > at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
> > at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:204)
> > at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:78)
> > at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
> > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> > at java.base/java.lang.Thread.run(Thread.java:833)
> > Caused by: org.apache.maven.plugin.PluginExecutionException: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:100)
> > at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:342)
> > ... 15 common frames omitted
> > Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> > at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolveInternal(DefaultPluginDependenciesResolver.java:214)
> > at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolve(DefaultPluginDependenciesResolver.java:158)
> > at org.apache.maven.plugin.internal.DefaultMavenPluginManager.createPluginRealm(DefaultMavenPluginManager.java:372)
> > at org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$setupPluginRealm$1(DefaultMavenPluginManager.java:335)
> > at org.mvndaemon.mvnd.cache.invalidating.InvalidatingPluginRealmCache.lambda$get$0(InvalidatingPluginRealmCache.java:89)
> > at org.mvndaemon.mvnd.cache.impl.TimestampCacheFactory$TimestampCache.lambda$computeIfAbsent$2(TimestampCacheFactory.java:181)
> > at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
> > at org.mvndaemon.mvnd.cache.impl.TimestampCacheFactory$TimestampCache.computeIfAbsent(TimestampCacheFactory.java:169)
> > at org.mvndaemon.mvnd.cache.invalidating.InvalidatingPluginRealmCache.get(InvalidatingPluginRealmCache.java:87)
> > at org.apache.maven.plugin.internal.DefaultMavenPluginManager.setupPluginRealm(DefaultMavenPluginManager.java:334)
> > at org.apache.maven.plugin.DefaultBuildPluginManager.getPluginRealm(DefaultBuildPluginManager.java:205)
> > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:98)
> > ... 16 common frames omitted
> > Caused by: org.eclipse.aether.collection.DependencyCollectionException: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> > at org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:260)
> > at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> > at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:305)
> > at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolveInternal(DefaultPluginDependenciesResolver.java:205)
> > ... 27 common frames omitted
> > Caused by: org.eclipse.aether.resolution.ArtifactDescriptorException: Failed to read artifact descriptor for org.ow2.asm:asm:jar:7.3.1
> > at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:242)
> > at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:172)
> > at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.resolveCachedArtifactDescriptor(BfDependencyCollector.java:462)
> > at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.resolveDescriptorForVersion(BfDependencyCollector.java:448)
> > at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$1(BfDependencyCollector.java:415)
> > at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
> > at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
> > at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$4(BfDependencyCollector.java:414)
> > ... 4 common frames omitted
> > Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: The following artifacts could not be resolved: org.ow2.asm:asm:pom:7.3.1 (absent): Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out
> > at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:456)
> > at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:261)
> > at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:242)
> > at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:231)
> > ... 11 common frames omitted
> > Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out
> > at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44)
> > at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417)
> > at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260)
> > at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:516)
> > at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:433)
> > ... 14 common frames omitted
> > Caused by: java.net.SocketTimeoutException: Read timed out
> > at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
> > at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)
> > at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:350)
> > at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:803)
> > at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
> > at java.base/sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:484)
> > at java.base/sun.security.ssl.SSLSocketInputRecord.readHeader(SSLSocketInputRecord.java:478)
> > at java.base/sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket(SSLSocketInputRecord.java:70)
> > at java.base/sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1465)
> > at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:1069)
> > at org.apache.http.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:137)
> > at org.apache.http.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:153)
> > at org.apache.http.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:280)
> > at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
> > at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
> > at org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
> > at org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
> > at org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:157)
> > at org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
> > at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
> > at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
> > at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
> > at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
> > at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
> > at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
> > at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:72)
> > at org.eclipse.aether.transport.http.HttpTransporter.execute(HttpTransporter.java:369)
> > at org.eclipse.aether.transport.http.HttpTransporter.implGet(HttpTransporter.java:319)
> > at org.eclipse.aether.spi.connector.transport.AbstractTransporter.get(AbstractTransporter.java:63)
> > at org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:482)
> > at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414)
> > ... 17 common frames omitted
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > I'd actually prefer using mvnw with maven 3.9.2 everywhere on GH actions. It works well in Camel Quarkus. Any concerns about that?
>
> Has that been reported on the maven side ? Is it something new ? specific to mvnd ? The socket timeout can be configured using per repository: `-Daether.connector.requestTimeout.[repo-id]=30000` or globally using `-Daether.connector.requestTimeout=30000`.
The actual issue is caused by the fact that Azure Cloud in which GH actions are running silently kills every connection after something like 4 minutes. These socket timeouts are a direct consequence of that. In older Maven versions this could be workarounded by passing something like `-Dmaven.wagon.httpconnectionManager.ttlSeconds=120`. Newer maven versions stopped using wagon by default. The replacement is implemented directly in maven-resolver, but the options to fine tune the connection lifecycle including `aether.connector.http.connectionMaxTtl` were missing till maven-resolver 1.9.8.
While Maven 3.9.2 is at maven-resolver 1.9.10, mvnd 1.0-m6-m39 is still at 1.9.7, so `aether.connector.http.connectionMaxTtl` does not work there.
So everything is basically fixed in Maven, there is nothing to report, only mvnd is a bit behind with the relevant versions. A 3.9.2 based release would help here, but using plain Maven 3.9.2 is also an option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592765064
For now, It was only used for the experimental incremental build to enable the parallel download of the pom files IIRC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594299957
> The failure in the checkstyle job is interesting for two reasons:
>
> 1. `checkstyle:checkstyle` requires resolved dependencies and because it runs before any `install` and because `https://repository.apache.org/snapshots/` are enabled by default, `checkstyle:checkstyle` pulls snapshots. I'd say CI should be reproducible and therefore should not rely on any snapshots other than local ones built from the current commit.
>
> 2. Rather than fixing the above, I wonder whether we still need checkstyle at all? I used to be a fan of it back in times when formatter and impsort plugins did not exist. But since I know the two, I tend to hate checkstyle. It just complains and cannot fix even basic things. Would anybody veto removing checkstyle and enabling formatter and impsort plugins as a part of the default build? This would also reduce the amount of clutter in the git history.
The biggest problem with removing the `checkstyle` is for external contributions: committers and regular contributors usually know the style patterns that we have, but external contributors usually don't.
That said: the way `checkstyle` verification is working nowadays is not adequate IMHO. It fails a lot due to the issues you pointed.
So, I am 0 on this and I'd like to hear what others have to say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592960727
okay for 3.9.2 if it can build the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594303527
Maybe one possibility here would be to run the formatter as a pre-commit hook, so we could remove this altogether as you suggested @ppalaga.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592877142
> I wonder which problem is that, @gnodet? Is it related to mvnd or mvnw (this PR touches both)?
>
> Anyway, mvnd 1.0-m6-m39-linux-amd64 was already used on some places before this PR. https://github.com/apache/camel/pull/10403/files#diff-fbabc4c33727e60ae5a15c24611fdf4f74126e38144bf0e0ef40b4499bdcc781R24-R28
It's mostly around a bunch of warnings (usage of deprecated stuff) printed by maven when using old plugins. Those should be toned down in 3.9.3 which is planned soon. But nothing major, it should definitely not fail the build (unless something enforces that there are no warnings at all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gzurowski commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "gzurowski (via GitHub)" <gi...@apache.org>.
gzurowski commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1602987267
> I assume the release process is not using any CI, so if certain Maven versions have known issues then the colleague performing the release can use whatever local Maven version that is known to work.
There's no CI involved in the release process, but we do use the Maven wrapper for performing releases. A good indicator if there a issues is usually to run `./mvnw release:prepare -Prelease -DdryRun` and confirm that it runs through the whole process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592756889
I wonder which problem is that, @gnodet? Is it related to mvnd or mvnw (this PR touches both)?
Anyway, mvnd 1.0-m6-m39-linux-amd64 was already used on some places before this PR.
https://github.com/apache/camel/pull/10403/files#diff-fbabc4c33727e60ae5a15c24611fdf4f74126e38144bf0e0ef40b4499bdcc781R24-R28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1603983045
Thanks. I wonder what we have to do make the snapshot deployment work with Maven 3.9.2 (or, the updated plugin that is causing this). I believe @cstamas commented on the ticket on ASF Jira, so let's keep this as 3.8.8 for now (we need the snapshot deployment job working because it's used by other sub-projects, as well as our GH actions) and try to work w/ INFRA.
I am not knowledgeable enough about Maven and/or the deployment plugin, but I'll be happy to help and try things on our CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1670175917
> I believe that we need to put it back
I'd kindly vote for not re-introducing checkstyle. It is just outputting cryptic error messages without being able to fix (or propose a fix for) even trivial things. If it only clearly said what it actually wants, I could live with it. Saying something like "bad method name" without saying what would be correct is just a time consuming crap. I'd be open to discuss other code quality tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592752536
@gnodet mentioned there was some problem with 3.9.2 and its better to wait for 3.9.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] cstamas commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1593208966
Azure issue is https://github.com/apache/maven-resolver/pull/274 and is released in resolver 1.9.8, Maven 3.9.2 uses resolver 1.9.10 so contains the "azure fix".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592805955
> I was wondering why they are red and the PR is marked as success.
Yes it is expected behavior since they are still experimental and they will eventually replace the existing jobs if we consider them reliable and helpful enough after some trial period
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1593213357
> So everything is basically fixed in Maven, there is nothing to report, only mvnd is a bit behind with the relevant versions. A 3.9.2 based release would help here, but using plain Maven 3.9.2 is also an option.
Cool, I'm planning a release in the coming weeks which will include 3.9.3 + alpha-6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594376533
> I'm completely against pre-commit hooks.
Any bad experience with those, @oscerd?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594438079
> We should update the minimum maven version to 3.9.2 and in the docs where we say what maven version is needed to build Camel v4.
Rather than hard coding the recommended Maven version in the docs, I'd vote for recommending to check it via `./mvnw -v` as done in https://github.com/apache/camel-website/pull/1015 - please comment there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1651700355
The formatter and impsort plugins cannot automatically fix most checkstyle violations, so I believe that we need to put it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1593799644
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592772355
Actually mvnd 1.0-m6-m39-linux-amd64 uses maven-resolver 1.9.7 which I am sure suffers from the socket timeouts in the very same way as the older mvnd 0.8.2. Here is an example seen in https://github.com/apache/camel/pull/10372 :
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack (process-sources) on project camel-spring-xml: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1: Failed to read artifact descriptor for org.ow2.asm:asm:jar:7.3.1: The following artifacts could not be resolved: org.ow2.asm:asm:pom:7.3.1 (absent): Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack (process-sources) on project camel-spring-xml: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:347)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:330)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:76)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:204)
at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:78)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:100)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:342)
... 15 common frames omitted
Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolveInternal(DefaultPluginDependenciesResolver.java:214)
at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolve(DefaultPluginDependenciesResolver.java:158)
at org.apache.maven.plugin.internal.DefaultMavenPluginManager.createPluginRealm(DefaultMavenPluginManager.java:372)
at org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$setupPluginRealm$1(DefaultMavenPluginManager.java:335)
at org.mvndaemon.mvnd.cache.invalidating.InvalidatingPluginRealmCache.lambda$get$0(InvalidatingPluginRealmCache.java:89)
at org.mvndaemon.mvnd.cache.impl.TimestampCacheFactory$TimestampCache.lambda$computeIfAbsent$2(TimestampCacheFactory.java:181)
at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
at org.mvndaemon.mvnd.cache.impl.TimestampCacheFactory$TimestampCache.computeIfAbsent(TimestampCacheFactory.java:169)
at org.mvndaemon.mvnd.cache.invalidating.InvalidatingPluginRealmCache.get(InvalidatingPluginRealmCache.java:87)
at org.apache.maven.plugin.internal.DefaultMavenPluginManager.setupPluginRealm(DefaultMavenPluginManager.java:334)
at org.apache.maven.plugin.DefaultBuildPluginManager.getPluginRealm(DefaultBuildPluginManager.java:205)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:98)
... 16 common frames omitted
Caused by: org.eclipse.aether.collection.DependencyCollectionException: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
at org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:260)
at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:305)
at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolveInternal(DefaultPluginDependenciesResolver.java:205)
... 27 common frames omitted
Caused by: org.eclipse.aether.resolution.ArtifactDescriptorException: Failed to read artifact descriptor for org.ow2.asm:asm:jar:7.3.1
at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:242)
at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:172)
at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.resolveCachedArtifactDescriptor(BfDependencyCollector.java:462)
at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.resolveDescriptorForVersion(BfDependencyCollector.java:448)
at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$1(BfDependencyCollector.java:415)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$4(BfDependencyCollector.java:414)
... 4 common frames omitted
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: The following artifacts could not be resolved: org.ow2.asm:asm:pom:7.3.1 (absent): Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out
at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:456)
at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:261)
at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:242)
at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:231)
... 11 common frames omitted
Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out
at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44)
at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417)
at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260)
at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:516)
at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:433)
... 14 common frames omitted
Caused by: java.net.SocketTimeoutException: Read timed out
at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)
at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:350)
at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:803)
at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
at java.base/sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:484)
at java.base/sun.security.ssl.SSLSocketInputRecord.readHeader(SSLSocketInputRecord.java:478)
at java.base/sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket(SSLSocketInputRecord.java:70)
at java.base/sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1465)
at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:1069)
at org.apache.http.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:137)
at org.apache.http.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:153)
at org.apache.http.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:280)
at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
at org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
at org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
at org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:157)
at org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:72)
at org.eclipse.aether.transport.http.HttpTransporter.execute(HttpTransporter.java:369)
at org.eclipse.aether.transport.http.HttpTransporter.implGet(HttpTransporter.java:319)
at org.eclipse.aether.spi.connector.transport.AbstractTransporter.get(AbstractTransporter.java:63)
at org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:482)
at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414)
... 17 common frames omitted
```
I'd actually prefer using mvnw with maven 3.9.2 everywhere on GH actions. It works well in Camel Quarkus. Any concerns about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592782087
> It is only used by the experimental incremental build to enable the parallel download of the pom files IIRC
Ah, thanks for the hint! So those incremental builds are a kind of optional alternative coverage done in other jobs? It explains a lot! I was wondering why they are red and the PR is marked as success. That perhaps lowers the necessity for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1602735739
@orpiske the revert breaks the invoker test in camel-package-maven-plugin. I wonder whether the failing snapshots deployment could be solved by using the older maven version only in the Camel Daily Snapshot Deploy job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1602749340
I assume the release process is not using any CI, so if certain Maven versions have known issues than the colleague performing the release can use whatever local Maven version that is known to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1602744296
> @orpiske the revert breaks the invoker test in camel-package-maven-plugin. I wonder whether the failing snapshots deployment could be solved by using the older maven version only in the Camel Daily Snapshot Deploy job?
Fine for me, but I am not sure if this wouldn't impact the release process. We probably need some feedback frrom @davsclaus, @oscerd and/or @gzurowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1602561146
Folks, as a heads up to everyone who contributed to this ticket: I had to [rollback](https://github.com/apache/camel/commit/7563a62ed7415848168c4474a04c5f79e70cb25c) the [upgrade to Maven 3.9.2](https://github.com/apache/camel/pull/10403/commits/0c9441c40c22d50f15969ff2cde6fc0559e1c12a) in mvnw as it was causing problems for deploying the snapshots (logged as [INFRA-24713](https://issues.apache.org/jira/browse/INFRA-24713)).
We'll need to investigate how to make the deployment work with Maven 3.9.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga merged pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #10403:
URL: https://github.com/apache/camel/pull/10403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592967673
We should update the minimum maven version to 3.9.2 and in the docs where we say what maven version is needed to build Camel v4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594399023
> Now I see that `camel-catalog-maven-grape` was added only yesterday, so it did not make it to the snapshots repo yet.
>
> I'd vote for merging this PR without waiting for it to appear.
+1 from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594396127
Now I see that `camel-catalog-maven-grape` was added only yesterday, so it did not make it to the snapshots repo yet.
I'd vote for merging this PR without waiting for it to appear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594287508
The failure in the checkstyle job is interesting for two reasons:
1. `checkstyle:checkstyle` requires resolved dependencies and because it runs before any `install` and because `https://repository.apache.org/snapshots/` are enabled by default, `checkstyle:checkstyle` pulls snapshots. I'd say CI should be reproducible and therefore should not rely on any snapshots other than local ones built from the current commit.
2. Rather than fixing the above, I wonder whether we still need checkstyle at all? I used to be a fan of it back in times when formatter and impsort plugins did not exist. But since I know the two, I tend to hate checkstyle. It just complains and cannot fix even basic things. Would anybody veto removing checkstyle and enabling formatter and impsort plugins as a part of the default build? This would also reduce the amount of clutter in the git history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594379392
> > I'm completely against pre-commit hooks.
>
> Any bad experience with those, @oscerd?
While working on Syndesis, at some point they were introduced and it was a really bad experience for me. I don't really think they bring any advantages, just headaches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1592881971
> Actually mvnd 1.0-m6-m39-linux-amd64 uses maven-resolver 1.9.7 which I am sure suffers from the socket timeouts in the very same way as the older mvnd 0.8.2. Here is an example seen in #10372 :
>
> ```
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack (process-sources) on project camel-spring-xml: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1: Failed to read artifact descriptor for org.ow2.asm:asm:jar:7.3.1: The following artifacts could not be resolved: org.ow2.asm:asm:pom:7.3.1 (absent): Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack (process-sources) on project camel-spring-xml: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:347)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:330)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:76)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:204)
> at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:78)
> at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution process-sources of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:100)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:342)
> ... 15 common frames omitted
> Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.2 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolveInternal(DefaultPluginDependenciesResolver.java:214)
> at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolve(DefaultPluginDependenciesResolver.java:158)
> at org.apache.maven.plugin.internal.DefaultMavenPluginManager.createPluginRealm(DefaultMavenPluginManager.java:372)
> at org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$setupPluginRealm$1(DefaultMavenPluginManager.java:335)
> at org.mvndaemon.mvnd.cache.invalidating.InvalidatingPluginRealmCache.lambda$get$0(InvalidatingPluginRealmCache.java:89)
> at org.mvndaemon.mvnd.cache.impl.TimestampCacheFactory$TimestampCache.lambda$computeIfAbsent$2(TimestampCacheFactory.java:181)
> at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
> at org.mvndaemon.mvnd.cache.impl.TimestampCacheFactory$TimestampCache.computeIfAbsent(TimestampCacheFactory.java:169)
> at org.mvndaemon.mvnd.cache.invalidating.InvalidatingPluginRealmCache.get(InvalidatingPluginRealmCache.java:87)
> at org.apache.maven.plugin.internal.DefaultMavenPluginManager.setupPluginRealm(DefaultMavenPluginManager.java:334)
> at org.apache.maven.plugin.DefaultBuildPluginManager.getPluginRealm(DefaultBuildPluginManager.java:205)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:98)
> ... 16 common frames omitted
> Caused by: org.eclipse.aether.collection.DependencyCollectionException: Failed to collect dependencies at org.apache.maven.plugins:maven-dependency-plugin:jar:3.1.2 -> org.apache.maven.shared:maven-dependency-analyzer:jar:1.11.1 -> org.ow2.asm:asm:jar:7.3.1
> at org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies(DependencyCollectorDelegate.java:260)
> at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:87)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:305)
> at org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver.resolveInternal(DefaultPluginDependenciesResolver.java:205)
> ... 27 common frames omitted
> Caused by: org.eclipse.aether.resolution.ArtifactDescriptorException: Failed to read artifact descriptor for org.ow2.asm:asm:jar:7.3.1
> at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:242)
> at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:172)
> at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.resolveCachedArtifactDescriptor(BfDependencyCollector.java:462)
> at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.resolveDescriptorForVersion(BfDependencyCollector.java:448)
> at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$1(BfDependencyCollector.java:415)
> at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
> at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
> at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$4(BfDependencyCollector.java:414)
> ... 4 common frames omitted
> Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: The following artifacts could not be resolved: org.ow2.asm:asm:pom:7.3.1 (absent): Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:456)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:261)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:242)
> at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:231)
> ... 11 common frames omitted
> Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact org.ow2.asm:asm:pom:7.3.1 from/to central (https://repo.maven.apache.org/maven2): Read timed out
> at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44)
> at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417)
> at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:516)
> at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:433)
> ... 14 common frames omitted
> Caused by: java.net.SocketTimeoutException: Read timed out
> at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
> at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)
> at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:350)
> at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:803)
> at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
> at java.base/sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:484)
> at java.base/sun.security.ssl.SSLSocketInputRecord.readHeader(SSLSocketInputRecord.java:478)
> at java.base/sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket(SSLSocketInputRecord.java:70)
> at java.base/sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1465)
> at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:1069)
> at org.apache.http.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:137)
> at org.apache.http.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:153)
> at org.apache.http.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:280)
> at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
> at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
> at org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
> at org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
> at org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:157)
> at org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
> at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
> at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
> at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
> at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
> at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
> at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
> at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:72)
> at org.eclipse.aether.transport.http.HttpTransporter.execute(HttpTransporter.java:369)
> at org.eclipse.aether.transport.http.HttpTransporter.implGet(HttpTransporter.java:319)
> at org.eclipse.aether.spi.connector.transport.AbstractTransporter.get(AbstractTransporter.java:63)
> at org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:482)
> at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414)
> ... 17 common frames omitted
> ```
>
> I'd actually prefer using mvnw with maven 3.9.2 everywhere on GH actions. It works well in Camel Quarkus. Any concerns about that?
Has that been reported on the maven side ? Is it something new ? specific to mvnd ?
The socket timeout can be configured using per repository:
`-Daether.connector.requestTimeout.[repo-id]=30000`
or globally using `-Daether.connector.requestTimeout=30000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1594366105
I'm completely against pre-commit hooks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10403:
URL: https://github.com/apache/camel/pull/10403#issuecomment-1651351627
Removing checkstyle prevents us from detecting violations like those fixed by https://github.com/apache/camel/pull/10829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org