You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "khrysto (via GitHub)" <gi...@apache.org> on 2026/09/03 10:00:50 UTC
[I] SQLLine 1.12.0: !tables no longer works due to JDBCThinResultSet#isClosed() reporting metadata ResultSet as closed [ignite]
khrysto opened a new issue, #13549:
URL: https://github.com/apache/ignite/issues/13549
After the upgrade to **SQLLine 1.12.0** introduced by commit 25ab91529c9f0b327ad677af90cdfa4e5a0c17e8 @zstan , SQLLine commands that rely on JDBC metadata result sets, such as !tables, no longer work correctly with the Ignite thin JDBC driver.
### Root Cause
Starting with SQLLine 1.12.0, SQLLine performs an explicit `ResultSet.isClosed()` check before reading from the result set.
For metadata queries, Ignite creates a JdbcThinResultSet with a null statement reference (stmt == null).
However, `JdbcThinResultSet.isClosed()` currently returns:
```
@Override public boolean isClosed() throws SQLException {
return closed || stmt == null || stmt.connection().isClosed();
}
```
As a result, any metadata ResultSet created without an associated statement is immediately reported as closed, even though it is perfectly usable.
Consequently, SQLLine 1.12.0 refuses to process the metadata result set and commands such as: `!tables` returns empty result
and this is the change in sqlline that introduced the check on the ResultSet isClosed
https://github.com/julianhyde/sqlline/commit/e0f9e9a1eb714a05988ae1323ff5e3bd463f64fb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQLLine 1.12.0: !tables no longer works due to JDBCThinResultSet#isClosed() reporting metadata ResultSet as closed [ignite]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on issue #13549:
URL: https://github.com/apache/ignite/issues/13549#issuecomment-5529808070
ok, assigned, how i also can help you ? Or it`s all that you need ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQLLine 1.12.0: !tables no longer works due to JDBCThinResultSet#isClosed() reporting metadata ResultSet as closed [ignite]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on issue #13549:
URL: https://github.com/apache/ignite/issues/13549#issuecomment-5551309544
@khrysto thanks, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQLLine 1.12.0: !tables no longer works due to JDBCThinResultSet#isClosed() reporting metadata ResultSet as closed [ignite]
Posted by "Adarsh-Me (via GitHub)" <gi...@apache.org>.
Adarsh-Me commented on issue #13549:
URL: https://github.com/apache/ignite/issues/13549#issuecomment-5524288738
Hi @zstan! I'd like to take this. The root cause is clear: metadata queries create `JdbcThinResultSet` with a null statement, and `isClosed()` then reports the result set as closed, which trips SQLLine 1.12.0's explicit `isClosed()` check before reading. I'd fix `JdbcThinResultSet.isClosed()` so a metadata result set with a null statement isn't reported as closed, and add coverage for metadata result sets (e.g. `!tables`-style queries). Could you please assign this to me? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQLLine 1.12.0: !tables no longer works due to JDBCThinResultSet#isClosed() reporting metadata ResultSet as closed [ignite]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on issue #13549:
URL: https://github.com/apache/ignite/issues/13549#issuecomment-5596919431
@Adarsh-Me are you plan to open a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQLLine 1.12.0: !tables no longer works due to JDBCThinResultSet#isClosed() reporting metadata ResultSet as closed [ignite]
Posted by "khrysto (via GitHub)" <gi...@apache.org>.
khrysto commented on issue #13549:
URL: https://github.com/apache/ignite/issues/13549#issuecomment-5540819828
@zstan , it was assigned to me instead of adarsh-me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQLLine 1.12.0: !tables no longer works due to JDBCThinResultSet#isClosed() reporting metadata ResultSet as closed [ignite]
Posted by "Adarsh-Me (via GitHub)" <gi...@apache.org>.
Adarsh-Me commented on issue #13549:
URL: https://github.com/apache/ignite/issues/13549#issuecomment-5972720772
@zstan yes — the PR is open: #13566 (`Fix #13549`), currently `clean` against master. It treats metadata result sets that have no owning statement as open, so `!tables` works under SQLLine 1.12.0. Sorry for the slow reply here; the discussion moved onto the PR. If useful, a reviewer with SQLLine exposure would help most on the CI evidence there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org