You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2026/07/22 06:38:44 UTC

[PR] fix: preserve wire request representation during signing [opendal-reqsign]

Xuanwo opened a new pull request, #785:
URL: https://github.com/apache/opendal-reqsign/pull/785

   Fixes #784.
   
   Request signing currently conflates service canonicalization with the wire URI. As a result, SigningRequest::build/apply can decode or otherwise rewrite caller-owned percent-encoded path and query representations, and failures can leave a partially modified request head.
   
   This change defines URI input as fully percent-encoded and wire-ready. Each service derives its canonical signing view locally, header authentication preserves URI identity, query authentication only appends protocol-owned fields, and core commits URI and headers atomically after successful signing. Existing Signer::sign, SignRequest::sign_request, and SigningRequest public shape stay unchanged, so OpenDAL call sites do not need changes.
   
   Compatibility note: third-party SignRequest implementations must treat SigningRequest path and query as read-only canonicalization inputs and construct query-authentication output from the raw URI. Implementations that relied on apply to rebuild or re-encode the URI may need adjustment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: preserve wire request representation during signing [opendal-reqsign]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #785:
URL: https://github.com/apache/opendal-reqsign/pull/785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org