[GitHub] [incubator-doris] blackfox1983 commented on a change in pull request #3813: [Doris On ES] Skip function_call expr when process predicate

[GitBox <gi...@apache.org>]

blackfox1983 commented on a change in pull request #3813:
URL: https://github.com/apache/incubator-doris/pull/3813#discussion_r437821664



##########
File path: be/src/exec/es/es_predicate.cpp
##########
@@ -49,6 +49,14 @@ namespace doris {
 
 using namespace std;
 
+#define RETURN_ERROR_IF_EXPR_IS_NOT_SLOTREF(expr) \
+    do { \
+            const Expr* expr_without_cast = Expr::expr_without_cast(expr); \
+            if (expr_without_cast->node_type() != TExprNodeType::SLOT_REF) { \
+                return Status::InternalError("build disjuncts failed: child is not slot ref"); \

Review comment:
       what is slot ref? add some example otherwise  it will be very confusing once this error occurs.
    e.g. slot ref(xx, xxx)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org