You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Jiri Daněk (Jira)" <ji...@apache.org> on 2020/11/11 11:04:00 UTC

[jira] [Updated] (DISPATCH-1814) Apply autofixes to resolve some flake8 code formatting issues

     [ https://issues.apache.org/jira/browse/DISPATCH-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jiri Daněk updated DISPATCH-1814:
---------------------------------
    Description: 
The general strategy for dealing with these in a scalable manner could be as follows

Identify warning we want to resolve, e.g. E701 multiple statements on a single line.

Remove E701 from flake8 ignore list in {{tests/tox.ini.in}}.

Run the autofixer

{code}
pip install autopep8
for f in `find -name "*.py"`; do autopep8 --in-place --select=E701 $f; done
for f in `find tests -name "*.py.in"`; do autopep8 --in-place --select=E701 $f; done
autopep8 --in-place --select=E701 tools/*.in
{code}

Wait about two minutes.

Review the diffs produced.

Submit a change request.

  was:
The general strategy for dealing with these in a scalable manner could be as follows

Identify warning we want to resolve, e.g. E701 multiple statements on a single line.

Remove E701 from flake8 ignore list in {{tests/tox.ini.in}}.

Run the autofixer

{code}
pip install autoflake8
for f in `find -name "*.py"`; do autopep8 --in-place --select=E701 $f; done
for f in `find tests -name "*.py.in"`; do autopep8 --in-place --select=E701 $f; done
autopep8 --in-place --select=E701 tools/*.in
{code}

Wait about two minutes.

Review the diffs produced.

Submit a change request.


> Apply autofixes to resolve some flake8 code formatting issues
> -------------------------------------------------------------
>
>                 Key: DISPATCH-1814
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1814
>             Project: Qpid Dispatch
>          Issue Type: Task
>    Affects Versions: 1.14.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Trivial
>
> The general strategy for dealing with these in a scalable manner could be as follows
> Identify warning we want to resolve, e.g. E701 multiple statements on a single line.
> Remove E701 from flake8 ignore list in {{tests/tox.ini.in}}.
> Run the autofixer
> {code}
> pip install autopep8
> for f in `find -name "*.py"`; do autopep8 --in-place --select=E701 $f; done
> for f in `find tests -name "*.py.in"`; do autopep8 --in-place --select=E701 $f; done
> autopep8 --in-place --select=E701 tools/*.in
> {code}
> Wait about two minutes.
> Review the diffs produced.
> Submit a change request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org