You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "TheR1sing3un (via GitHub)" <gi...@apache.org> on 2024/12/31 09:08:44 UTC
[PR] [HUDI-8802] Avoid unnecessary conversion between HoodieIndexAvroRecord and HoodieAvroRecord in HoodieFileSliceReader [hudi]
TheR1sing3un opened a new pull request, #12559:
URL: https://github.com/apache/hudi/pull/12559
When `HoodieFileSliceReader` performs reading:
For base records that have a corresponding update record in the log file, it first converts the HoodieAvroIndexRecord format that it reads from the Base Reader to the HoodieAvroRecord format. Then when it performs the merge, it convert itself to the HoodieAvroIndexRecord, and since it was the HoodieAvroIndexRecord in the first place, this extra conversion is not necessary.
`HoodieFileSlice`
<img width="1157" alt="image" src="https://github.com/user-attachments/assets/fbfccea6-5307-48b3-9bfc-555f4db2edd3" />
`HoodieAvroRecordMerger`
<img width="1413" alt="image" src="https://github.com/user-attachments/assets/03754ded-23fb-4e01-ba02-93098205bd7b" />
### Change Logs
1. avoid unnecessary conversion between HoodieIndexAvroRecord and HoodieAvroRecord in HoodieFileSliceReader
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
low
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
low
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
none
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Change Logs and Impact were stated clearly
- [x] Adequate tests were added if applicable
- [x] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8802] Avoid unnecessary conversion between HoodieIndexAvroRecord and HoodieAvroRecord in HoodieFileSliceReader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12559:
URL: https://github.com/apache/hudi/pull/12559#issuecomment-2566320011
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d7717b2167c66deb2a2565e7aed28a5a7b17b0b8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2604",
"triggerID" : "d7717b2167c66deb2a2565e7aed28a5a7b17b0b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7717b2167c66deb2a2565e7aed28a5a7b17b0b8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8802] Avoid unnecessary conversion between HoodieIndexAvroRecord and HoodieAvroRecord in HoodieFileSliceReader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12559:
URL: https://github.com/apache/hudi/pull/12559#issuecomment-2566266956
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d7717b2167c66deb2a2565e7aed28a5a7b17b0b8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d7717b2167c66deb2a2565e7aed28a5a7b17b0b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7717b2167c66deb2a2565e7aed28a5a7b17b0b8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8802] Avoid unnecessary conversion between HoodieIndexAvroRecord and HoodieAvroRecord in HoodieFileSliceReader [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12559:
URL: https://github.com/apache/hudi/pull/12559#issuecomment-2566268191
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d7717b2167c66deb2a2565e7aed28a5a7b17b0b8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2604",
"triggerID" : "d7717b2167c66deb2a2565e7aed28a5a7b17b0b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7717b2167c66deb2a2565e7aed28a5a7b17b0b8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8802] Avoid unnecessary conversion between HoodieIndexAvroRecord and HoodieAvroRecord in HoodieFileSliceReader [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #12559:
URL: https://github.com/apache/hudi/pull/12559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org