You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geronimo.apache.org by "Gianny Damour (JIRA)" <de...@geronimo.apache.org> on 2005/09/13 15:13:55 UTC

[jira] Closed: (GERONIMO-1004) SequenceTablePrimaryKeyGenerator transaction handling is broken (Tranql)

     [ http://issues.apache.org/jira/browse/GERONIMO-1004?page=all ]
     
Gianny Damour closed GERONIMO-1004:
-----------------------------------

    Resolution: Fixed

This is now fixed.

SequenceTablePrimaryKeyGenerator:
1. suspends in-flight transactions
2. starts a new one to perform its operation
3. commit its transaction
4. resume the transaction suspended at step 1.

There was also another problem with the implementation: it was setting the auto commit in an XA connection, which is not allowed as pointed out by Jeremy. 

> SequenceTablePrimaryKeyGenerator transaction handling is broken (Tranql)
> ------------------------------------------------------------------------
>
>          Key: GERONIMO-1004
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1004
>      Project: Geronimo
>         Type: Bug
>   Components: transaction manager
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: Gianny Damour
>      Fix For: 1.0-M5
>  Attachments: pkgenerator.diff
>
> Tranql's SequenceTablePrimaryKeyGenerator thinks it is doing its work in a new transaction, but it is not.  It breaks the current transaction, and fails if you are using an xa datasource.
> The current openejb setup code does not allow for passing a separate ds in for the pk generator than for cmp.  Therefore it appears that essentially doing a "requires new" call is best.  However, the transaction module classes are not available in tranql since transaction depends on tranql (using a cache class).   I think moving the SequenceTable pk generator to openejb is the most practical short term solution but I will look for others.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira