[GitHub] [beam] kennknowles commented on a change in pull request #14239: Update script and instructions for cutting release branch

[GitBox <gi...@apache.org>]

kennknowles commented on a change in pull request #14239:
URL: https://github.com/apache/beam/pull/14239#discussion_r611930687



##########
File path: release/src/main/scripts/cut_release_branch.sh
##########
@@ -127,10 +124,6 @@ echo "==================Current working branch======================="
 echo ${RELEASE_BRANCH}
 echo "==============================================================="
 
-sed -i -e "s/${DEV}/${RELEASE}/g" gradle.properties
-sed -i -e "s/${DEV}/${RELEASE}/g" sdks/python/apache_beam/version.py
-sed -i -e "s/${DEV}/${RELEASE}/g" sdks/go/pkg/beam/core/core.go
-# TODO: [BEAM-4767]
 sed -i -e "s/'beam-master-.*'/'beam-${RELEASE}'/g" runners/google-cloud-dataflow-java/build.gradle

Review comment:
       Retroactive CC @emilymye that this is the only remaining edit of the release branch at cut time. I would like to also eliminate this one so the release branch can be perfectly analogous to master branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org