You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/05 16:32:50 UTC
[GitHub] williaster commented on issue #5758: [SIP-5] Refactor and improve
histogram
williaster commented on issue #5758: [SIP-5] Refactor and improve histogram
URL: https://github.com/apache/incubator-superset/pull/5758#issuecomment-418796073
this `lgtm`, I like the `WithLegend` component, it seems like it should be pretty flexible ( ;) ) with the various render props, too.
My only comment would be on aesthetics for the `bottom` orientation: should we match the `flex-end` `justify-content` alignment of the `top` orientation for consistency instead of `center`? could get @elibrumbaugh 's thoughts on this as well, or I'm happy merging this to land it and making tweaks later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org