[GitHub] [tvm] MasterJH5574 opened a new pull request, #15478: [BugFix][TIR] ThreadSync with shared.dyn awareness

["MasterJH5574 (via GitHub)" <gi...@apache.org>]

MasterJH5574 opened a new pull request, #15478:
URL: https://github.com/apache/tvm/pull/15478

   This PR fixes an issue of the ThreadSync pass.
   
   Prior to this PR, the pass is not aware of `shared.dyn` scope whose users all share a same shared memory space. This feature is not necessarily already revealed in the IR at the time of applying ThreadSync. This means that when applying ThreadSync, in the IR, each buffer of `shared.dyn` scope still uses its own data Var, and ThreadSync is thus unable to detect the conflict properly and insert the sync instructions properly.
   
   This PR explicitly makes ThreadSync be aware of the `shared.dyn` scope, and redirect all the access vars of `shared.dyn` memory to a common var, so that ThreadSync analysis can find out the conflict and insert the sync instructions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #15478: [BugFix][TIR] ThreadSync with shared.dyn awareness

["junrushao (via GitHub)" <gi...@apache.org>]

junrushao merged PR #15478:
URL: https://github.com/apache/tvm/pull/15478


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15478: [BugFix][TIR] ThreadSync with shared.dyn awareness

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #15478:
URL: https://github.com/apache/tvm/pull/15478#issuecomment-1664924707

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org