You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by vcharmcaster <gi...@git.apache.org> on 2016/07/05 19:15:40 UTC
[GitHub] lucene-solr pull request #48: moved common string to constant file
GitHub user vcharmcaster opened a pull request:
https://github.com/apache/lucene-solr/pull/48
moved common string to constant file
removed magic code. moved repeated string in final variable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vcharmcaster/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 2c5abe1107441884ee95b9eab87d07bfa6c3c450
Author: Vaibhav kulkarni <vc...@users.noreply.github.com>
Date: 2016-07-05T19:14:22Z
moved common string to constant file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Posted by cpoerschke <gi...@git.apache.org>.
Github user cpoerschke closed the pull request at:
https://github.com/apache/lucene-solr/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Posted by cpoerschke <gi...@git.apache.org>.
Github user cpoerschke commented on the pull request:
https://github.com/apache/lucene-solr/pull/48#issuecomment-43208284
Extra commit above relates to [comments] on SOLR-6067 ticket.
[comments]: https://issues.apache.org/jira/browse/SOLR-6067?focusedCommentId=13998594&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13998594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Posted by cpoerschke <gi...@git.apache.org>.
Github user cpoerschke commented on the pull request:
https://github.com/apache/lucene-solr/pull/48#issuecomment-43537862
Commit above adds similar buildAndRunCollectorChain method to Grouping.java to reduce code duplication there too a little.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Posted by cpoerschke <gi...@git.apache.org>.
Github user cpoerschke commented on the pull request:
https://github.com/apache/lucene-solr/pull/48#issuecomment-42980446
https://issues.apache.org/jira/i#browse/SOLR-6067 now opened for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org