You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/11/19 06:31:32 UTC

Review Request 28215: [HELIX-550] Shutdown GenericHelixController on disconnect (port to master)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28215/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-550


Repository: helix-git


Description
-------

This is a port to master of this PR: https://github.com/apache/helix/pull/11/files#diff-866b65f4aa4b4753224ff615eb2efc1eR533

commit bfb4a3d34228f5c3806b1eee9e98f401386e66a9
Author: Kanak Biscuitwala <ka...@hotmail.com>
Date:   Tue Nov 18 21:23:29 2014 -0800

    [HELIX-550] Shutdown GenericHelixController on disconnect

:100644 100644 aef636e... 113cace... M	helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
:100644 100644 295b69c... fafe604... M	helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java


Diffs
-----

  helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java 6fa3d05 
  helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java 295b69c 

Diff: https://reviews.apache.org/r/28215/diff/


Testing
-------


Thanks,

Kanak Biscuitwala


Re: Review Request 28215: [HELIX-550] Shutdown GenericHelixController on disconnect (port to master)

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28215/#review62599
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On Nov. 19, 2014, 5:31 a.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28215/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 5:31 a.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-550
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> This is a port to master of this PR: https://github.com/apache/helix/pull/11/files#diff-866b65f4aa4b4753224ff615eb2efc1eR533
> 
> commit bfb4a3d34228f5c3806b1eee9e98f401386e66a9
> Author: Kanak Biscuitwala <ka...@hotmail.com>
> Date:   Tue Nov 18 21:23:29 2014 -0800
> 
>     [HELIX-550] Shutdown GenericHelixController on disconnect
> 
> :100644 100644 aef636e... 113cace... M	helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
> :100644 100644 295b69c... fafe604... M	helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java
> 
> 
> Diffs
> -----
> 
>   helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java 6fa3d05 
>   helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java 295b69c 
> 
> Diff: https://reviews.apache.org/r/28215/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>