You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/05/24 22:30:00 UTC
[jira] [Commented] (IMPALA-11313) impala-shell's PyPi form factor still suffers from IMPALA-10299
[ https://issues.apache.org/jira/browse/IMPALA-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541737#comment-17541737 ]
ASF subversion and git services commented on IMPALA-11313:
----------------------------------------------------------
Commit a11450db86e69b25345baf74c52a1592a27c42df in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a11450db8 ]
IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package
Thrift 0.11.0 has known issues where Unicode errors are
not handler properly, including one case where the client
can hang. The traditional form factor for impala-shell
uses a patched Thrift that fixes those issues, but the
PyPi package uses the unpatched Thrift 0.11.0.
This modifies the requirements.txt file to use Thrift 0.14.2,
which has fixes for these Unicode issues. Thrift 0.14.2 has
a slightly different error message, so this amends the
allowed error messages in test_utf8_decoding_error_handling().
This is a bit awkward, given that the Python code generation
continues to happen with Thrift 0.11.0. Comparing the
Python code for Thrift 0.11 vs Thrift 0.14, I didn't see
noticeable differences. Given that the client can hang,
this seems worth fixing ahead of the full conversion to
Thrift 0.14 for all of Impala.
Testing:
- Ran the Unicode error handling tests with a PyPi
impala-shell
- Ran the shell tests normally
Change-Id: I63e0a5dda98df20c9184a347397118b1f3529603
Reviewed-on: http://gerrit.cloudera.org:8080/18560
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> impala-shell's PyPi form factor still suffers from IMPALA-10299
> ---------------------------------------------------------------
>
> Key: IMPALA-11313
> URL: https://issues.apache.org/jira/browse/IMPALA-11313
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Priority: Critical
>
> The PyPi form factor for impala-shell gets its dependencies from the requirements.txt file, and that file uses "thrift==0.11.0". This Thrift version does not have fixes for THRIFT-2087 or THRIFT-5303 , so it will not successfully run the tests added for IMPALA-10299/IMPALA-10145.
> One option is to use a patched Thrift 0.11.0 for impala-shell's PyPi package. The other option is to use Thrift 0.14.2. My testing suggests that with a minor test fix, Thrift 0.14.2 works fine, even if we don't upgrade Thrift in other locations (i.e. the Thrift Python code generation is still generated by Thrift 0.11).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org