You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/12/05 11:53:12 UTC
Review Request 16039: CLOUDSTACK-5381: Fixed code related custom host name
(vm.instancename.flag)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16039/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-5381
https://issues.apache.org/jira/browse/CLOUDSTACK-5381
Repository: cloudstack-git
Description
-------
Following test cases failed with "Vm display name should match the given name"
test_01_custom_hostname_instancename_false
test_02_custom_hostname_instancename_false
It was comparing vm id with the vm name, instead it should compare the display name with the passed value. Later on, as written in description it checks whether the internal name does not include display name.
Also, removing duplicate test case test_02_custom_hostname_instancename_false.
Diffs
-----
test/integration/component/test_custom_hostname.py 95ce1c5
Diff: https://reviews.apache.org/r/16039/diff/
Testing
-------
Tested locally on KVM advanced zone setup.
Log:
test_01_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
Verify custom hostname for the instance when ... ok
test_02_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
Verify custom hostname for the instance when ... skipped 'Skip'
test_01_user_provided_hostname (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
Verify user provided hostname to an instance ... skipped 'skip'
test_02_instancename_from_default_configuration (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
Verify for globally set instancename ... skipped 'skip'
test_03_duplicate_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
Test the duplicate name when old VM is in non-expunged state ... skipped 'skip'
test_04_edit_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
Test Edit the Display name Through the UI. ... skipped 'skip'
test_05_unsupported_chars_in_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
Test Unsupported chars in the display name ... skipped 'skip'
----------------------------------------------------------------------
Ran 7 tests in 201.397s
OK (skipped=6)
Thanks,
Ashutosh Kelkar
Re: Review Request 16039: CLOUDSTACK-5381: Fixed code related custom host
name (vm.instancename.flag)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16039/#review29808
-----------------------------------------------------------
Commit 0c64eda53f158cc671fc3e1515a76b5e0475447b in branch refs/heads/4.3 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0c64eda ]
CLOUDSTACK-5381: Corrected code related custom host name (vm.instancename)
- ASF Subversion and Git Services
On Dec. 5, 2013, 10:53 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16039/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 10:53 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5381
> https://issues.apache.org/jira/browse/CLOUDSTACK-5381
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Following test cases failed with "Vm display name should match the given name"
> test_01_custom_hostname_instancename_false
> test_02_custom_hostname_instancename_false
>
> It was comparing vm id with the vm name, instead it should compare the display name with the passed value. Later on, as written in description it checks whether the internal name does not include display name.
>
> Also, removing duplicate test case test_02_custom_hostname_instancename_false.
>
>
> Diffs
> -----
>
> test/integration/component/test_custom_hostname.py 95ce1c5
>
> Diff: https://reviews.apache.org/r/16039/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced zone setup.
>
> Log:
> test_01_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
> Verify custom hostname for the instance when ... ok
> test_02_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
> Verify custom hostname for the instance when ... skipped 'Skip'
> test_01_user_provided_hostname (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Verify user provided hostname to an instance ... skipped 'skip'
> test_02_instancename_from_default_configuration (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Verify for globally set instancename ... skipped 'skip'
> test_03_duplicate_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test the duplicate name when old VM is in non-expunged state ... skipped 'skip'
> test_04_edit_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test Edit the Display name Through the UI. ... skipped 'skip'
> test_05_unsupported_chars_in_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test Unsupported chars in the display name ... skipped 'skip'
>
> ----------------------------------------------------------------------
> Ran 7 tests in 201.397s
>
> OK (skipped=6)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16039: CLOUDSTACK-5381: Fixed code related custom host
name (vm.instancename.flag)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16039/#review29807
-----------------------------------------------------------
Commit 9b2addf4810c52d6bb25cf76e6cbd93a510e1337 in branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9b2addf ]
CLOUDSTACK-5381: Corrected code related custom host name (vm.instancename)
- ASF Subversion and Git Services
On Dec. 5, 2013, 10:53 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16039/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 10:53 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5381
> https://issues.apache.org/jira/browse/CLOUDSTACK-5381
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Following test cases failed with "Vm display name should match the given name"
> test_01_custom_hostname_instancename_false
> test_02_custom_hostname_instancename_false
>
> It was comparing vm id with the vm name, instead it should compare the display name with the passed value. Later on, as written in description it checks whether the internal name does not include display name.
>
> Also, removing duplicate test case test_02_custom_hostname_instancename_false.
>
>
> Diffs
> -----
>
> test/integration/component/test_custom_hostname.py 95ce1c5
>
> Diff: https://reviews.apache.org/r/16039/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced zone setup.
>
> Log:
> test_01_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
> Verify custom hostname for the instance when ... ok
> test_02_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
> Verify custom hostname for the instance when ... skipped 'Skip'
> test_01_user_provided_hostname (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Verify user provided hostname to an instance ... skipped 'skip'
> test_02_instancename_from_default_configuration (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Verify for globally set instancename ... skipped 'skip'
> test_03_duplicate_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test the duplicate name when old VM is in non-expunged state ... skipped 'skip'
> test_04_edit_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test Edit the Display name Through the UI. ... skipped 'skip'
> test_05_unsupported_chars_in_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test Unsupported chars in the display name ... skipped 'skip'
>
> ----------------------------------------------------------------------
> Ran 7 tests in 201.397s
>
> OK (skipped=6)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16039: CLOUDSTACK-5381: Fixed code related custom host
name (vm.instancename.flag)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16039/#review29809
-----------------------------------------------------------
Commit dfded8834cbf01f85d81fb269f0d3a7f8436a351 in branch refs/heads/4.2 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=dfded88 ]
CLOUDSTACK-5381: Corrected code related custom host name (vm.instancename)
- ASF Subversion and Git Services
On Dec. 5, 2013, 10:53 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16039/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 10:53 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5381
> https://issues.apache.org/jira/browse/CLOUDSTACK-5381
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Following test cases failed with "Vm display name should match the given name"
> test_01_custom_hostname_instancename_false
> test_02_custom_hostname_instancename_false
>
> It was comparing vm id with the vm name, instead it should compare the display name with the passed value. Later on, as written in description it checks whether the internal name does not include display name.
>
> Also, removing duplicate test case test_02_custom_hostname_instancename_false.
>
>
> Diffs
> -----
>
> test/integration/component/test_custom_hostname.py 95ce1c5
>
> Diff: https://reviews.apache.org/r/16039/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced zone setup.
>
> Log:
> test_01_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
> Verify custom hostname for the instance when ... ok
> test_02_custom_hostname_instancename_false (test_custom_hostname_fixed.TestInstanceNameFlagFalse)
> Verify custom hostname for the instance when ... skipped 'Skip'
> test_01_user_provided_hostname (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Verify user provided hostname to an instance ... skipped 'skip'
> test_02_instancename_from_default_configuration (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Verify for globally set instancename ... skipped 'skip'
> test_03_duplicate_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test the duplicate name when old VM is in non-expunged state ... skipped 'skip'
> test_04_edit_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test Edit the Display name Through the UI. ... skipped 'skip'
> test_05_unsupported_chars_in_display_name (test_custom_hostname_fixed.TestInstanceNameFlagTrue)
> Test Unsupported chars in the display name ... skipped 'skip'
>
> ----------------------------------------------------------------------
> Ran 7 tests in 201.397s
>
> OK (skipped=6)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>