You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/02 09:59:02 UTC

[GitHub] [apisix-website] yzeng25 commented on a change in pull request #1002: chore: reformat scripts and config

yzeng25 commented on a change in pull request #1002:
URL: https://github.com/apache/apisix-website/pull/1002#discussion_r841056808



##########
File path: scripts/common.js
##########
@@ -1,60 +1,58 @@
 const projects = [
   {
-    name: "apisix-ingress-controller",
-    branch: "master",
-    hasChangelog: true
+    name: 'apisix-ingress-controller',
+    branch: 'master',
+    hasChangelog: true,
   },
   {
-    name: "apisix",
-    branch: "master",
-    hasChangelog: true
+    name: 'apisix',
+    branch: 'master',
+    hasChangelog: true,
   },
   {
-    name: "apisix-dashboard",
-    branch: "master",
-    hasChangelog: true
+    name: 'apisix-dashboard',
+    branch: 'master',
+    hasChangelog: true,
   },
   {
-    name: "apisix-docker",
-    branch: "master",
+    name: 'apisix-docker',
+    branch: 'master',
     hasChangelog: false,
   },
   {
-    name: "apisix-helm-chart",
-    branch: "master",
+    name: 'apisix-helm-chart',
+    branch: 'master',
     hasChangelog: false,
   },
   {
-    name: "apisix-java-plugin-runner",
-    branch: "main",
-    hasChangelog: true
+    name: 'apisix-java-plugin-runner',
+    branch: 'main',
+    hasChangelog: true,
   },
   {
-    name: "apisix-go-plugin-runner",
-    branch: "master",
-    hasChangelog: true
+    name: 'apisix-go-plugin-runner',
+    branch: 'master',
+    hasChangelog: true,
   },
   {
-    name: "apisix-python-plugin-runner",
-    branch: "master",
-    hasChangelog: true
-  }
+    name: 'apisix-python-plugin-runner',
+    branch: 'master',
+    hasChangelog: true,
+  },
 ];
 
-const languages = ["en", "zh", "es"];
+const languages = ['en', 'zh', 'es'];

Review comment:
       I think we don't need es(Spanish) for now. There was a contributor doing Spanish and he passed away about a year ago, then the process of translation is stopped, see https://github.com/apache/apisix/issues/3587#issuecomment-818397330.
   
   I  would suggest to transfer this part as an issue and see if anyone could pick it up.
   
   ```suggestion
   const languages = ['en', 'zh'];
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org