You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/05/14 20:36:29 UTC

[GitHub] [geode] jdeppe-pivotal opened a new pull request #6483: GEODE-9278: Increase timeout for rsync_down task

jdeppe-pivotal opened a new pull request #6483:
URL: https://github.com/apache/geode/pull/6483


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #6483: GEODE-9278: Increase timeout for rsync_down task

Posted by GitBox <gi...@apache.org>.

rhoughton-pivot commented on pull request #6483:
URL: https://github.com/apache/geode/pull/6483#issuecomment-841531175


   Windows rsync has been all over the place, from 5 minutes, to pushing just at the 15minute limit, with no clear indicator to me as to what the hold up could be. The hosts are all in the same GCP zone, and should be a *very* fast file transfer. So, pushing the timeout seems fine to me, until we have time to debug the infrastructure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal commented on pull request #6483: GEODE-9278: Increase timeout for rsync_down task

Posted by GitBox <gi...@apache.org>.

onichols-pivotal commented on pull request #6483:
URL: https://github.com/apache/geode/pull/6483#issuecomment-841530444


   @rhoughton-pivot has been heavily involved in this area so I'd like his thoughts on this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #6483: GEODE-9278: Increase timeout for rsync_down task

Posted by GitBox <gi...@apache.org>.

jdeppe-pivotal merged pull request #6483:
URL: https://github.com/apache/geode/pull/6483


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal edited a comment on pull request #6483: GEODE-9278: Increase timeout for rsync_down task

Posted by GitBox <gi...@apache.org>.

onichols-pivotal edited a comment on pull request #6483:
URL: https://github.com/apache/geode/pull/6483#issuecomment-841530444


   @rhoughton-pivot has been heavily involved in this area so I'd like his thoughts on this.  successful rsync takes much less than 15 minutes...a timeout usually means we failed to cleanup all java child processes...since we already have 5 retries, increasing this timeout may just mean it will take 100 minutes instead of 75 minutes to fail....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org