You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Florian Holeczek (JIRA)" <ji...@apache.org> on 2012/10/28 23:01:11 UTC

[jira] [Created] (JSPWIKI-750) PageViewPluginTest is failing very often when using a JDK 7

Florian Holeczek created JSPWIKI-750:
----------------------------------------

             Summary: PageViewPluginTest is failing very often when using a JDK 7
                 Key: JSPWIKI-750
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-750
             Project: JSPWiki
          Issue Type: Bug
          Components: Servlet Container/Java compatibility
    Affects Versions: 2.8.4, 2.9
         Environment: Oracle JDK 7
            Reporter: Florian Holeczek
            Assignee: Florian Holeczek
            Priority: Minor
             Fix For: 2.9.1


The PageViewPluginTest tests will fail if they aren't executed in the same order like they appear in the source file.
JUnit never gave any grants in terms of execution ordering. Quite the contrary, relying on execution ordering is considered to be bad practice [1].
However, up to JDK 6, it seemed to always be the same ordering like in the source code, so the tests were thought to be stable and deterministic. JDK 7 now changed this situation [2].

Thanks to Glen Mazza for reporting this [3]!

[1] http://www.javaworld.com/jw-12-2000/jw-1221-junit.html?page=2
[2] http://stackoverflow.com/questions/3693626/how-to-run-test-methods-in-spec-order-in-junit4
[3] http://mail-archives.apache.org/mod_mbox/incubator-jspwiki-dev/201210.mbox/%3C508C0CBB.4030304%40gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (JSPWIKI-750) PageViewPluginTest is failing very often when using a JDK 7

Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Holeczek closed JSPWIKI-750.
------------------------------------


Closing this, since 2.9 has been released
                
> PageViewPluginTest is failing very often when using a JDK 7
> -----------------------------------------------------------
>
>                 Key: JSPWIKI-750
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-750
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Servlet Container/Java compatibility
>    Affects Versions: 2.8.4, 2.9
>         Environment: Oracle JDK 7
>            Reporter: Florian Holeczek
>            Assignee: Florian Holeczek
>            Priority: Minor
>             Fix For: 2.9
>
>
> The PageViewPluginTest tests will fail if they aren't executed in the same order like they appear in the source file.
> JUnit never gave any grants in terms of execution ordering. Quite the contrary, relying on execution ordering is considered to be bad practice [1].
> However, up to JDK 6, it seemed to always be the same ordering like in the source code, so the tests were thought to be stable and deterministic. JDK 7 now changed this situation [2].
> Thanks to Glen Mazza for reporting this [3]!
> [1] http://www.javaworld.com/jw-12-2000/jw-1221-junit.html?page=2
> [2] http://stackoverflow.com/questions/3693626/how-to-run-test-methods-in-spec-order-in-junit4
> [3] http://mail-archives.apache.org/mod_mbox/incubator-jspwiki-dev/201210.mbox/%3C508C0CBB.4030304%40gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (JSPWIKI-750) PageViewPluginTest is failing very often when using a JDK 7

Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Holeczek resolved JSPWIKI-750.
--------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.9.1)
                   2.9

Because of JSPWIKI-665, I took the small solution and implemented the workaround mentioned at [1] (see above). Seems to work, couldn't reproduce the test failures anymore.
                
> PageViewPluginTest is failing very often when using a JDK 7
> -----------------------------------------------------------
>
>                 Key: JSPWIKI-750
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-750
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Servlet Container/Java compatibility
>    Affects Versions: 2.8.4, 2.9
>         Environment: Oracle JDK 7
>            Reporter: Florian Holeczek
>            Assignee: Florian Holeczek
>            Priority: Minor
>             Fix For: 2.9
>
>
> The PageViewPluginTest tests will fail if they aren't executed in the same order like they appear in the source file.
> JUnit never gave any grants in terms of execution ordering. Quite the contrary, relying on execution ordering is considered to be bad practice [1].
> However, up to JDK 6, it seemed to always be the same ordering like in the source code, so the tests were thought to be stable and deterministic. JDK 7 now changed this situation [2].
> Thanks to Glen Mazza for reporting this [3]!
> [1] http://www.javaworld.com/jw-12-2000/jw-1221-junit.html?page=2
> [2] http://stackoverflow.com/questions/3693626/how-to-run-test-methods-in-spec-order-in-junit4
> [3] http://mail-archives.apache.org/mod_mbox/incubator-jspwiki-dev/201210.mbox/%3C508C0CBB.4030304%40gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira