You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2018/01/30 15:15:12 UTC

Re: logging-log4j2 git commit: LOG4J2-2236 Removed unnecessary dependency on jcommander since Log4j uses embedded picocli since 2.9.

Will you port to master?

Gary

On Jan 30, 2018 07:03, <rp...@apache.org> wrote:

> Repository: logging-log4j2
> Updated Branches:
>   refs/heads/release-2.x 21bc3aa3b -> 4da4243f5
>
>
> LOG4J2-2236 Removed unnecessary dependency on jcommander since Log4j uses
> embedded picocli since 2.9.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> commit/4da4243f
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/4da4243f
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/4da4243f
>
> Branch: refs/heads/release-2.x
> Commit: 4da4243f50ba2af3ad69f69f56c37ff7d6eac250
> Parents: 21bc3aa
> Author: rpopma <rp...@apache.org>
> Authored: Tue Jan 30 23:03:32 2018 +0900
> Committer: rpopma <rp...@apache.org>
> Committed: Tue Jan 30 23:03:32 2018 +0900
>
> ----------------------------------------------------------------------
>  log4j-core/pom.xml      | 6 ------
>  pom.xml                 | 5 -----
>  src/changes/changes.xml | 3 +++
>  3 files changed, 3 insertions(+), 11 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 4da4243f/log4j-core/pom.xml
> ----------------------------------------------------------------------
> diff --git a/log4j-core/pom.xml b/log4j-core/pom.xml
> index 4ae808a..4241457 100644
> --- a/log4j-core/pom.xml
> +++ b/log4j-core/pom.xml
> @@ -144,12 +144,6 @@
>        <artifactId>commons-csv</artifactId>
>        <optional>true</optional>
>      </dependency>
> -    <!-- Command line for TCP and UDP servers -->
> -    <dependency>
> -      <groupId>com.beust</groupId>
> -      <artifactId>jcommander</artifactId>
> -      <optional>true</optional>
> -    </dependency>
>
>      <!-- TEST DEPENDENCIES -->
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 4da4243f/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 362eb41..7bc1339 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -297,11 +297,6 @@
>          <version>3.7</version>
>        </dependency>
>        <dependency>
> -        <groupId>com.beust</groupId>
> -        <artifactId>jcommander</artifactId>
> -        <version>1.48</version>
> -      </dependency>
> -      <dependency>
>          <groupId>ch.qos.logback</groupId>
>          <artifactId>logback-classic</artifactId>
>          <version>${logbackVersion}</version>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 4da4243f/src/changes/changes.xml
> ----------------------------------------------------------------------
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index 431e665..016a857 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -31,6 +31,9 @@
>           - "remove" - Removed
>      -->
>      <release version="2.11.0" date="2018-xx-xx" description="GA Release
> 2.11.0">
> +      <action issue="LOG4J2-2236" dev="rpopma" type="update">
> +        Removed unnecessary dependency on jcommander since Log4j uses
> embedded picocli since 2.9.
> +      </action>
>        <action issue="LOG4J2-1883" dev="rpopma" type="add" due-to="Anthony
> Maire">
>          Added support for precise (micro and nanosecond) timestamps when
> running on Java 9. A limited number of precise %d date formats are
> supported with PatternLayout. POTENTIAL BREAKING CHANGE: The XML, JSON and
> YAML formats have changed: they no longer have the "timeMillis" attribute
> and instead have an "Instant" element with "epochSecond" and "nanoOfSecond"
> attributes.
>        </action>
>
>