You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2016/06/16 13:38:37 UTC

[GitHub] brooklyn-server pull request #206: Add debug log for onEffectorStarting meth...

GitHub user bostko opened a pull request:

    https://github.com/apache/brooklyn-server/pull/206

    Add debug log for onEffectorStarting method

    - the method is used by proxy calls and exceptions in here could be stripped out

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bostko/brooklyn-server log_on_effector_starting_events

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #206
    
----
commit e90b463c3b5d24501f242f74f62fb2a61470b6e8
Author: Valentin Aitken <bo...@gmail.com>
Date:   2016-06-16T13:38:06Z

    Add debug log for onEffectorStarting method
    
    - the method is used by proxy calls and exceptions in here could be stripped out

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #206: Add debug log for onEffectorStarting meth...

Posted by bostko <gi...@git.apache.org>.
Github user bostko closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/206


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #206: Add debug log for onEffectorStarting method

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/206
  
    @bostko I've opened https://issues.apache.org/jira/browse/BROOKLYN-313 to give lots of detail, and created https://github.com/apache/brooklyn-server/pull/245 to fix it. Can you review that please? If you're happy with the fix there, then can you close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #206: Add debug log for onEffectorStarting method

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/206
  
    I think there is a more general fix we need, for us not logging the cause of exceptions. I'm going to dig into that a little more. Hopefully we can do something at a higher level that means we don't need this log statement. We also want to avoid logging it multiple times.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---