You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2025/05/16 18:52:55 UTC
[PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]
tustvold opened a new pull request, #370:
URL: https://github.com/apache/arrow-rs-object-store/pull/370
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #370:
URL: https://github.com/apache/arrow-rs-object-store/pull/370#discussion_r2093548639
##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
/// Retry request error
#[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);
Review Comment:
I double checked and indeed I agree this error is not public
```shell
cargo doc --all-features --open
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #370:
URL: https://github.com/apache/arrow-rs-object-store/pull/370#discussion_r2093542463
##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
/// Retry request error
#[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);
Review Comment:
I'm not sure RetryError is actually public, but regardless all the fields are crate private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #370:
URL: https://github.com/apache/arrow-rs-object-store/pull/370#discussion_r2093540432
##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
/// Retry request error
#[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);
Review Comment:
Isn't this a breaking public API change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #370:
URL: https://github.com/apache/arrow-rs-object-store/pull/370#discussion_r2093541015
##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
/// Retry request error
#[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);
+
+/// Box error to avoid large error variant
+#[derive(Debug)]
+struct RetryErrorImpl {
Review Comment:
Doesn't this mean the fields are now not public on the error 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #370:
URL: https://github.com/apache/arrow-rs-object-store/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix 1.87 Clippy Lints [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #370:
URL: https://github.com/apache/arrow-rs-object-store/pull/370#discussion_r2093548639
##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
/// Retry request error
#[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);
Review Comment:
I double checked and indeed I agree this error is not public
```shell
cargo doc --all-features --open
```
##########
src/client/retry.rs:
##########
@@ -33,7 +33,11 @@ use web_time::{Duration, Instant};
/// Retry request error
#[derive(Debug, thiserror::Error)]
-pub struct RetryError {
+pub struct RetryError(Box<RetryErrorImpl>);
Review Comment:
I double checked and indeed I agree this error is not public
```shell
cargo doc --all-features --open
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org