[PR] Fixed: Regressions in CheckoutServices, RequirementServicesScript and OrderDeliveryServices (OFBIZ-13707) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak opened a new pull request, #2448:
URL: https://github.com/apache/ofbiz-framework/pull/2448

   Three regressions from the minilang conversion and a later rename:
   
   - CheckoutServices removes the contact mech of a purpose from the shopping cart before adding the new one, so submitting a checkout step again with a changed address no longer leaves the previous shipping, billing, phone and email contact mechs in the cart, as the replacing addContactMech did before the rename.
   - autoAssignRequirementToSupplier assigns a requirement with a quantity of 0, as the minilang if-not-empty did, instead of skipping it because of Groovy truthiness.
   - sendOrderDeliveryScheduleNotification no longer throws a NullPointerException when the current user has no email address or the schedule is missing, it skips the sender and logs that there is insufficient data, as the minilang did.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: Regressions in CheckoutServices, RequirementServicesScript and OrderDeliveryServices (OFBIZ-13707) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak merged PR #2448:
URL: https://github.com/apache/ofbiz-framework/pull/2448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org