You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/06/04 05:27:24 UTC

[GitHub] [carbondata] nihal0107 opened a new pull request #4145: [WIP]handle geo udf to allow zero or more whitespace

nihal0107 opened a new pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145


    ### Why is this PR needed?
    Currently, regex of geo UDF is not allowing zero space between UDF name and parenthesis. It always expects a single space in between. For ex: `linestring (120.184179 30.327465)`. Because of this sometimes using the UDFs without space is not giving the expected result. 
    
    ### What changes were proposed in this PR?
   Allow zero space between UDFs and parenthesis.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-855571556


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#discussion_r645434666



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala
##########
@@ -639,6 +639,14 @@ class GeoTest extends QueryTest with BeforeAndAfterAll with BeforeAndAfterEach {
         Row(120197093, 30325985),
         Row(120196020, 30321651),
         Row(120198638, 30323540)))
+    checkAnswer(

Review comment:
       Can do checkanswer with previous query. Can assign previous query to DF




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-854570237


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5498/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-854415774


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3753/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-855571499


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-854415774






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] nihal0107 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-854483753


   retest this please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-855622351


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5510/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-854639058


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3758/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-854634014


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5501/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
nihal0107 commented on a change in pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#discussion_r645508235



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala
##########
@@ -639,6 +639,14 @@ class GeoTest extends QueryTest with BeforeAndAfterAll with BeforeAndAfterEach {
         Row(120197093, 30325985),
         Row(120196020, 30321651),
         Row(120198638, 30323540)))
+    checkAnswer(

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-854555660


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3755/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] asfgit closed pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4145: [CARBONDATA-4196] Allow zero or more white space in GEO UDFs

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4145:
URL: https://github.com/apache/carbondata/pull/4145#issuecomment-855621564


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3767/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org