[GitHub] [druid] adarshsanjeev commented on a diff in pull request #13967: Detect segment unavailability for queries in broker

["adarshsanjeev (via GitHub)" <gi...@apache.org>]

adarshsanjeev commented on code in PR #13967:
URL: https://github.com/apache/druid/pull/13967#discussion_r1192462419


##########
server/src/main/java/org/apache/druid/server/http/MetadataResource.java:
##########
@@ -165,6 +173,104 @@ public Response getAllUsedSegments(
     return builder.entity(authorizedSegments).build();
   }
 
+  @GET
+  @Path("/changedSegments")
+  @Produces(MediaType.APPLICATION_JSON)
+  public Response getChangedSegments(

Review Comment:
   Could you document what each parameter is supposed to be? I think it's not clear from the name and it's hard to tell what they should be without going through ChangeRequestHistory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org