You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/08/11 04:50:20 UTC

[GitHub] [kvrocks] tisonkun commented on a diff in pull request #1668: Tentatively remove GCC TSAN in CI to avoid blocking PRs

tisonkun commented on code in PR #1668:
URL: https://github.com/apache/kvrocks/pull/1668#discussion_r1290890718


##########
.github/workflows/kvrocks.yaml:
##########
@@ -134,12 +134,6 @@ jobs:
             with_sanitizer: -DENABLE_ASAN=ON
             without_jemalloc: -DDISABLE_JEMALLOC=ON
             compiler: clang

Review Comment:
   ```suggestion
               compiler: clang
             # FIXME - tsan.so not found https://github.com/apache/kvrocks/issues/1662
             # - name: Ubuntu GCC TSan
             #   os: ubuntu-20.04
             #   without_jemalloc: -DDISABLE_JEMALLOC=ON
             #   with_sanitizer: -DENABLE_TSAN=ON
             #   compiler: gcc
             #   ignore_when_tsan: -tags="ignore_when_tsan"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org